[jboss-jira] [JBoss JIRA] (WFCORE-3359) Use non-compact ModelNode.writeString to print operation failure messages on multiple lines in the log

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477110#comment-13477110 ] 

Brian Stansberry commented on WFCORE-3359:
------------------------------------------

I agree about log parsing. And these message already can be multiline, and for service issues almost always will be. So any parsing people are doing already has to account for multiline. If that kind of parsing is just scanning for the presence of certain message codes that would still work. It's only if they are doing complex parsing that they would have a problem and I have no interest in trying to avoid breaking changes to that kind of thing.

Also, if people are truly parsing the string into DMR, or into some other data structure that has the same parsing rules as DMR, then this would not be a breaking change, as the non-compact output is a valid, parseable DMR representation.

> Use non-compact ModelNode.writeString to print operation failure messages on multiple lines in the log
> ------------------------------------------------------------------------------------------------------
>
>                 Key: WFCORE-3359
>                 URL: https://issues.jboss.org/browse/WFCORE-3359
>             Project: WildFly Core
>          Issue Type: Enhancement
>          Components: Domain Management
>            Reporter: Brian Stansberry
>            Assignee: Brian Stansberry
>            Priority: Minor
>
> When we log operation failures perhaps the logging would be better if we used the non-compact representation of DMR.
> We need to confirm with GSS and folks  like [~jamezp] that this is a good idea. A concern is the message has more lines, but it's often already a multi-line message.
> See also some of the discussion on JBEAP-10713.
> I think this is basically a change at:
> https://github.com/wildfly/wildfly-core/blob/master/controller/src/main/java/org/jboss/as/controller/AbstractOperationContext.java#L982
> https://github.com/wildfly/wildfly-core/blob/master/controller/src/main/java/org/jboss/as/controller/AbstractOperationContext.java#L1003
> https://github.com/wildfly/wildfly-core/blob/master/controller/src/main/java/org/jboss/as/controller/AbstractOperationContext.java#L1007



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)