[jboss-jira] [JBoss JIRA] (WFLY-13433) Improve capability support in EJB3 subsystem

[Richard Achmatowicz (Jira)]

    [ https://issues.redhat.com/browse/WFLY-13433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14080265#comment-14080265 ] 

Richard Achmatowicz edited comment on WFLY-13433 at 5/6/20 2:10 PM:
--------------------------------------------------------------------

Introducing a central repository for capability names and references, as used in Undertow:
{noformat}
public final class Capabilities {
    /*
     * Capabilities defined in this subsystem
     */
    public static final String CAPABILITY_APPLICATION_SECURITY_DOMAIN = "org.wildfly.ejb3.application-security-domain";
    public static final String CAPABILITY_CLUSTERED_SINGLETON = "org.wildfly.ejb3.clustered.singleton";
    public static final String CAPABILITY_EJB3 = "org.wildfly.ejb3";
    public static final String CAPABILITY_EJB_REMOTE = "org.wildfly.ejb.remote";
    public static final String CAPABILITY_IDENTITY = "org.wildfly.ejb3.identity";
    public static final String CAPABILITY_REMOTE_CLIENT_CONFIGURATOR = "org.wildfly.ejb3.remote.client-configurator";

    /*
     * Capabilities referenced by this subsystem
     */
    public static final String REF_GLOBAL_DEFAULT_LOCAL_PROVIDER = "org.wildfly.transactions.global-default-local-provider";
    public static final String REF_JACC_POLICY = "org.wildfly.security.jacc-policy";
    public static final String REF_SECURITY_DOMAIN = "org.wildfly.security.security-domain";
    public static final String REF_LEGACY_SERVER_SECURITY_MANAGER = "org.wildfly.legacy-security.server-security-manager";
    public static final String REF_TXN_SYNCHRONIZATION_REGISTRY = "org.wildfly.transactions.transaction-synchronization-registry";
}
{noformat}

This will eliminate the many capability-related text strings being defined across the resources in EJB3 subsystem and give a better picture of what is defined and what is referenced.

Had a chat with Paul and he mentioned that for capabilities in the top section which are not intended to be consumed by other subsystems, and just act to express dependencies, these strings should really be private (or at worst protected); in other words, not visible to the outside world. Most capabilities defined within EJB3 resources will not be consumed from outside, but a few may.


was (Author: rachmato):
Introducing a central repository for capability names and references, as used in Undertow:
{noformat}
public final class Capabilities {
    /*
     * Capabilities defined in this subsystem
     */
    public static final String CAPABILITY_APPLICATION_SECURITY_DOMAIN = "org.wildfly.ejb3.application-security-domain";
    public static final String CAPABILITY_CLUSTERED_SINGLETON = "org.wildfly.ejb3.clustered.singleton";
    public static final String CAPABILITY_EJB3 = "org.wildfly.ejb3";
    public static final String CAPABILITY_EJB_REMOTE = "org.wildfly.ejb.remote";
    public static final String CAPABILITY_IDENTITY = "org.wildfly.ejb3.identity";
    public static final String CAPABILITY_REMOTE_CLIENT_CONFIGURATOR = "org.wildfly.ejb3.remote.client-configurator";

    /*
     * Capabilities referenced by this subsystem
     */
    public static final String REF_GLOBAL_DEFAULT_LOCAL_PROVIDER = "org.wildfly.transactions.global-default-local-provider";
    public static final String REF_JACC_POLICY = "org.wildfly.security.jacc-policy";
    public static final String REF_SECURITY_DOMAIN = "org.wildfly.security.security-domain";
    public static final String REF_LEGACY_SERVER_SECURITY_MANAGER = "org.wildfly.legacy-security.server-security-manager";
    public static final String REF_TXN_SYNCHRONIZATION_REGISTRY = "org.wildfly.transactions.transaction-synchronization-registry";
}
{noformat}

This will eliminate the many capability-related text strings being defined across the resources in EJB3 subsystem and give a better picture of what is defined and what is referenced.

> Improve capability support in EJB3 subsystem
> --------------------------------------------
>
>                 Key: WFLY-13433
>                 URL: https://issues.redhat.com/browse/WFLY-13433
>             Project: WildFly
>          Issue Type: Enhancement
>          Components: EJB
>    Affects Versions: 20.0.0.Beta1
>            Reporter: Richard Achmatowicz
>            Assignee: Richard Achmatowicz
>            Priority: Major
>
> Survey all external subsystem dependencies and introduce capability based dependencies where required.



--
This message was sent by Atlassian Jira
(v7.13.8#713008)