[jboss-svn-commits] JBL Code SVN: r5802 - labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners

jboss-svn-commits at lists.jboss.org jboss-svn-commits at lists.jboss.org
Fri Aug 11 16:22:06 EDT 2006


Author: tfennelly
Date: 2006-08-11 16:22:01 -0400 (Fri, 11 Aug 2006)
New Revision: 5802

Added:
   labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig1.xml
   labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig2.xml
   labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig3.xml
   labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig4.xml
   labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig5.xml
   labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig6.xml
   labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfigX.xml
   labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/ListenerManagerTest.java
Log:
added configuration tests

Added: labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig1.xml
===================================================================
--- labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig1.xml	2006-08-11 20:16:03 UTC (rev 5801)
+++ labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig1.xml	2006-08-11 20:22:01 UTC (rev 5802)
@@ -0,0 +1,34 @@
+<!-- Invalid commandConnFactoryClass -->
+
+<FileCopierExample
+	commandConnFactoryClass="X"
+	commandJndiType="jboss"
+	commandJndiURL="localhost"
+	commandIsTopic="false"
+	messageSelector="gpMsgSelector='test'"
+	commandJndiName="queue/A"
+>
+   <PollDirectoryExample
+   	listenerClass="org.jboss.soa.esb.listeners.DirectoryPoller"
+   	actionClass="org.jboss.soa.esb.actions.FileCopier"
+   	pollLatencySecs="2"
+	maxThreads="2"
+	inputDirURI="@qa.build@/inputDir"
+	inputSuffix=".inp"
+	workSuffix=".COPYING"
+	errorSuffix=".COPYERR"
+	postDirURI="@qa.build@/inputDoneDir"
+	postSuffix=".DONE"
+	postDelete="n"
+   > 
+	<CopyTo 
+		copyToDirURI="@qa.build@/copiedTo" 
+		copyToSuffix=".outFromFirst"
+	/>
+	<CopyTo 
+		copyToDirURI="@qa.build@/copiedTo" 
+		copyToSuffix=".outFromSecond"
+	/>
+   </PollDirectoryExample>
+
+</FileCopierExample>

Added: labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig2.xml
===================================================================
--- labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig2.xml	2006-08-11 20:16:03 UTC (rev 5801)
+++ labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig2.xml	2006-08-11 20:22:01 UTC (rev 5802)
@@ -0,0 +1,34 @@
+<!-- Invalid commandJndiType -->
+
+<FileCopierExample
+	commandConnFactoryClass="ConnectionFactory"
+	commandJndiType="X"
+	commandJndiURL="localhost"
+	commandIsTopic="false"
+	messageSelector="gpMsgSelector='test'"
+	commandJndiName="queue/A"
+>
+   <PollDirectoryExample
+   	listenerClass="org.jboss.soa.esb.listeners.DirectoryPoller"
+   	actionClass="org.jboss.soa.esb.actions.FileCopier"
+   	pollLatencySecs="2"
+	maxThreads="2"
+	inputDirURI="@qa.build@/inputDir"
+	inputSuffix=".inp"
+	workSuffix=".COPYING"
+	errorSuffix=".COPYERR"
+	postDirURI="@qa.build@/inputDoneDir"
+	postSuffix=".DONE"
+	postDelete="n"
+   > 
+	<CopyTo 
+		copyToDirURI="@qa.build@/copiedTo" 
+		copyToSuffix=".outFromFirst"
+	/>
+	<CopyTo 
+		copyToDirURI="@qa.build@/copiedTo" 
+		copyToSuffix=".outFromSecond"
+	/>
+   </PollDirectoryExample>
+
+</FileCopierExample>

Added: labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig3.xml
===================================================================
--- labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig3.xml	2006-08-11 20:16:03 UTC (rev 5801)
+++ labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig3.xml	2006-08-11 20:22:01 UTC (rev 5802)
@@ -0,0 +1,34 @@
+<!-- Invalid commandJndiURL -->
+
+<FileCopierExample
+	commandConnFactoryClass="ConnectionFactory"
+	commandJndiType="jboss"
+	commandJndiURL="X"
+	commandIsTopic="false"
+	messageSelector="gpMsgSelector='test'"
+	commandJndiName="queue/A"
+>
+   <PollDirectoryExample
+   	listenerClass="org.jboss.soa.esb.listeners.DirectoryPoller"
+   	actionClass="org.jboss.soa.esb.actions.FileCopier"
+   	pollLatencySecs="2"
+	maxThreads="2"
+	inputDirURI="@qa.build@/inputDir"
+	inputSuffix=".inp"
+	workSuffix=".COPYING"
+	errorSuffix=".COPYERR"
+	postDirURI="@qa.build@/inputDoneDir"
+	postSuffix=".DONE"
+	postDelete="n"
+   > 
+	<CopyTo 
+		copyToDirURI="@qa.build@/copiedTo" 
+		copyToSuffix=".outFromFirst"
+	/>
+	<CopyTo 
+		copyToDirURI="@qa.build@/copiedTo" 
+		copyToSuffix=".outFromSecond"
+	/>
+   </PollDirectoryExample>
+
+</FileCopierExample>

Added: labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig4.xml
===================================================================
--- labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig4.xml	2006-08-11 20:16:03 UTC (rev 5801)
+++ labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig4.xml	2006-08-11 20:22:01 UTC (rev 5802)
@@ -0,0 +1,34 @@
+<!-- Invalid commandIsTopic -->
+
+<FileCopierExample
+	commandConnFactoryClass="ConnectionFactory"
+	commandJndiType="jboss"
+	commandJndiURL="localhost"
+	commandIsTopic="X"
+	messageSelector="gpMsgSelector='test'"
+	commandJndiName="queue/A"
+>
+   <PollDirectoryExample
+   	listenerClass="org.jboss.soa.esb.listeners.DirectoryPoller"
+   	actionClass="org.jboss.soa.esb.actions.FileCopier"
+   	pollLatencySecs="2"
+	maxThreads="2"
+	inputDirURI="@qa.build@/inputDir"
+	inputSuffix=".inp"
+	workSuffix=".COPYING"
+	errorSuffix=".COPYERR"
+	postDirURI="@qa.build@/inputDoneDir"
+	postSuffix=".DONE"
+	postDelete="n"
+   > 
+	<CopyTo 
+		copyToDirURI="@qa.build@/copiedTo" 
+		copyToSuffix=".outFromFirst"
+	/>
+	<CopyTo 
+		copyToDirURI="@qa.build@/copiedTo" 
+		copyToSuffix=".outFromSecond"
+	/>
+   </PollDirectoryExample>
+
+</FileCopierExample>

Added: labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig5.xml
===================================================================
--- labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig5.xml	2006-08-11 20:16:03 UTC (rev 5801)
+++ labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig5.xml	2006-08-11 20:22:01 UTC (rev 5802)
@@ -0,0 +1,34 @@
+<!-- Invalid messageSelector -->
+
+<FileCopierExample
+	commandConnFactoryClass="ConnectionFactory"
+	commandJndiType="jboss"
+	commandJndiURL="localhost"
+	commandIsTopic="false"
+	messageSelector="X"
+	commandJndiName="queue/A"
+>
+   <PollDirectoryExample
+   	listenerClass="org.jboss.soa.esb.listeners.DirectoryPoller"
+   	actionClass="org.jboss.soa.esb.actions.FileCopier"
+   	pollLatencySecs="2"
+	maxThreads="2"
+	inputDirURI="@qa.build@/inputDir"
+	inputSuffix=".inp"
+	workSuffix=".COPYING"
+	errorSuffix=".COPYERR"
+	postDirURI="@qa.build@/inputDoneDir"
+	postSuffix=".DONE"
+	postDelete="n"
+   > 
+	<CopyTo 
+		copyToDirURI="@qa.build@/copiedTo" 
+		copyToSuffix=".outFromFirst"
+	/>
+	<CopyTo 
+		copyToDirURI="@qa.build@/copiedTo" 
+		copyToSuffix=".outFromSecond"
+	/>
+   </PollDirectoryExample>
+
+</FileCopierExample>

Added: labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig6.xml
===================================================================
--- labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig6.xml	2006-08-11 20:16:03 UTC (rev 5801)
+++ labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfig6.xml	2006-08-11 20:22:01 UTC (rev 5802)
@@ -0,0 +1,34 @@
+<!-- Invalid commandJndiName -->
+
+<FileCopierExample
+	commandConnFactoryClass="ConnectionFactory"
+	commandJndiType="jboss"
+	commandJndiURL="localhost"
+	commandIsTopic="false"
+	messageSelector="gpMsgSelector='test'"
+	commandJndiName="X"
+>
+   <PollDirectoryExample
+   	listenerClass="org.jboss.soa.esb.listeners.DirectoryPoller"
+   	actionClass="org.jboss.soa.esb.actions.FileCopier"
+   	pollLatencySecs="2"
+	maxThreads="2"
+	inputDirURI="@qa.build@/inputDir"
+	inputSuffix=".inp"
+	workSuffix=".COPYING"
+	errorSuffix=".COPYERR"
+	postDirURI="@qa.build@/inputDoneDir"
+	postSuffix=".DONE"
+	postDelete="n"
+   > 
+	<CopyTo 
+		copyToDirURI="@qa.build@/copiedTo" 
+		copyToSuffix=".outFromFirst"
+	/>
+	<CopyTo 
+		copyToDirURI="@qa.build@/copiedTo" 
+		copyToSuffix=".outFromSecond"
+	/>
+   </PollDirectoryExample>
+
+</FileCopierExample>

Added: labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfigX.xml
===================================================================
--- labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfigX.xml	2006-08-11 20:16:03 UTC (rev 5801)
+++ labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/BadConfigX.xml	2006-08-11 20:22:01 UTC (rev 5802)
@@ -0,0 +1,34 @@
+<!-- Invalid ? -->
+
+<FileCopierExample
+	commandConnFactoryClass="ConnectionFactory"
+	commandJndiType="jboss"
+	commandJndiURL="localhost"
+	commandIsTopic="false"
+	messageSelector="gpMsgSelector='test'"
+	commandJndiName="queue/A"
+>
+   <PollDirectoryExample
+   	listenerClass="org.jboss.soa.esb.listeners.DirectoryPoller"
+   	actionClass="org.jboss.soa.esb.actions.FileCopier"
+   	pollLatencySecs="2"
+	maxThreads="2"
+	inputDirURI="@qa.build@/inputDir"
+	inputSuffix=".inp"
+	workSuffix=".COPYING"
+	errorSuffix=".COPYERR"
+	postDirURI="@qa.build@/inputDoneDir"
+	postSuffix=".DONE"
+	postDelete="n"
+   > 
+	<CopyTo 
+		copyToDirURI="@qa.build@/copiedTo" 
+		copyToSuffix=".outFromFirst"
+	/>
+	<CopyTo 
+		copyToDirURI="@qa.build@/copiedTo" 
+		copyToSuffix=".outFromSecond"
+	/>
+   </PollDirectoryExample>
+
+</FileCopierExample>

Added: labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/ListenerManagerTest.java
===================================================================
--- labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/ListenerManagerTest.java	2006-08-11 20:16:03 UTC (rev 5801)
+++ labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/ListenerManagerTest.java	2006-08-11 20:22:01 UTC (rev 5802)
@@ -0,0 +1,74 @@
+/*
+ * JBoss, Home of Professional Open Source
+ * Copyright 2006, JBoss Inc., and individual contributors as indicated
+ * by the @authors tag. See the copyright.txt in the distribution for a
+ * full listing of individual contributors.
+ *
+ * This is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as
+ * published by the Free Software Foundation; either version 2.1 of
+ * the License, or (at your option) any later version.
+ *
+ * This software is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this software; if not, write to the Free
+ * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA, or see the FSF site: http://www.fsf.org.
+ */
+package org.jboss.soa.esb.listeners;
+
+import javax.naming.CommunicationException;
+import javax.naming.NameNotFoundException;
+
+import org.jboss.soa.esb.util.ClassUtils;
+import org.jboss.soa.esb.util.ListenerUtils;
+
+import junit.framework.AssertionFailedError;
+import junit.framework.TestCase;
+
+/**
+ * QA tests for the Listener Manager class - otherwise known as the {@link org.jboss.soa.esb.listeners.GpListener}.
+ * <p/>
+ * General tests around the command queue, bad configurations etc.
+ * 
+ * @author <a href="mailto:tom.fennelly at jboss.com">tom.fennelly at jboss.com</a>
+ */
+public class ListenerManagerTest extends TestCase {
+
+	protected void setUp() throws Exception {
+	}
+
+	public void test() throws Exception {
+		test("BadConfig1.xml", "commandConnFactoryClass", NameNotFoundException.class); // REVIEW: Usability - Not getting a specific error message here.  How about a "BadListenerConfigurationException"??
+		test("BadConfig2.xml", "commandJndiType", IllegalArgumentException.class); // REVIEW: Usability - Not getting a specific error message here.  How about a "BadListenerConfigurationException"??
+		test("BadConfig3.xml", "commandJndiURL", CommunicationException.class); // REVIEW: Usability - Not getting a specific error message here.  How about a "BadListenerConfigurationException"??
+		test("BadConfig4.xml", "commandIsTopic", null); // BUG: Exception getting swallowed here!!! Should only accept boolean values.
+		test("BadConfig5.xml", "messageSelector", null); // BUG: Exception getting swallowed here!!! Sould only accept NV Pairs.
+		test("BadConfig6.xml", "commandJndiName", NameNotFoundException.class); // REVIEW: Usability - Not getting a specific error message here.  How about a "BadListenerConfigurationException"??
+	}
+
+	public void test(String config, String paramName, Class expectedException) throws Exception {
+		try {
+			ListenerUtils.createGpListener(ClassUtils.toResourcePath(getClass().getPackage()) + "/" + config);
+			if(expectedException != null) {
+				fail("[Param '" + paramName + "' test] No exception being thrown for bad param config!! Expected Exception: " + expectedException.getName());
+			}
+		} catch(AssertionFailedError e) {
+			throw e;
+		} catch(Throwable e) {
+			if(expectedException == null) {
+				fail("[Param '" + paramName + "' test] Unexpected Exception: " + e.getClass().getName() + ": " + e.getMessage());
+			} else if(!expectedException.isInstance(e)) {
+				fail("[Param '" + paramName + "' test] Expected Exception: " + expectedException.getName() + ".  Got " + e.getClass().getName() + ": " + e.getMessage());
+			}
+			// Is the expected Exception!!
+		}
+	}
+	
+	protected void tearDown() throws Exception {
+	}	
+}




More information about the jboss-svn-commits mailing list