[jboss-svn-commits] JBL Code SVN: r5803 - labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners

[jboss-svn-commits at lists.jboss.org]

Author: tfennelly
Date: 2006-08-11 16:23:04 -0400 (Fri, 11 Aug 2006)
New Revision: 5803

Modified:
   labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/ListenerManagerTest.java
Log:
added configuration tests

Modified: labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/ListenerManagerTest.java
===================================================================
--- labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/ListenerManagerTest.java	2006-08-11 20:22:01 UTC (rev 5802)
+++ labs/jbossesb/trunk/qa/junit/src/org/jboss/soa/esb/listeners/ListenerManagerTest.java	2006-08-11 20:23:04 UTC (rev 5803)
@@ -42,16 +42,16 @@
 	protected void setUp() throws Exception {
 	}
 
-	public void test() throws Exception {
-		test("BadConfig1.xml", "commandConnFactoryClass", NameNotFoundException.class); // REVIEW: Usability - Not getting a specific error message here.  How about a "BadListenerConfigurationException"??
-		test("BadConfig2.xml", "commandJndiType", IllegalArgumentException.class); // REVIEW: Usability - Not getting a specific error message here.  How about a "BadListenerConfigurationException"??
-		test("BadConfig3.xml", "commandJndiURL", CommunicationException.class); // REVIEW: Usability - Not getting a specific error message here.  How about a "BadListenerConfigurationException"??
-		test("BadConfig4.xml", "commandIsTopic", null); // BUG: Exception getting swallowed here!!! Should only accept boolean values.
-		test("BadConfig5.xml", "messageSelector", null); // BUG: Exception getting swallowed here!!! Sould only accept NV Pairs.
-		test("BadConfig6.xml", "commandJndiName", NameNotFoundException.class); // REVIEW: Usability - Not getting a specific error message here.  How about a "BadListenerConfigurationException"??
+	public void test_BadConfigurations() throws Exception {
+		test_BadConfigurations("BadConfig1.xml", "commandConnFactoryClass", NameNotFoundException.class); // REVIEW: Usability - Not getting a specific error message here.  How about a "BadListenerConfigurationException"??
+		test_BadConfigurations("BadConfig2.xml", "commandJndiType", IllegalArgumentException.class); // REVIEW: Usability - Not getting a specific error message here.  How about a "BadListenerConfigurationException"??
+		test_BadConfigurations("BadConfig3.xml", "commandJndiURL", CommunicationException.class); // REVIEW: Usability - Not getting a specific error message here.  How about a "BadListenerConfigurationException"??
+		test_BadConfigurations("BadConfig4.xml", "commandIsTopic", null); // BUG: Exception getting swallowed here!!! Should only accept boolean values.
+		test_BadConfigurations("BadConfig5.xml", "messageSelector", null); // BUG: Exception getting swallowed here!!! Sould only accept NV Pairs.
+		test_BadConfigurations("BadConfig6.xml", "commandJndiName", NameNotFoundException.class); // REVIEW: Usability - Not getting a specific error message here.  How about a "BadListenerConfigurationException"??
 	}
 
-	public void test(String config, String paramName, Class expectedException) throws Exception {
+	public void test_BadConfigurations(String config, String paramName, Class expectedException) throws Exception {
 		try {
 			ListenerUtils.createGpListener(ClassUtils.toResourcePath(getClass().getPackage()) + "/" + config);
 			if(expectedException != null) {