[jbosstools-dev] [Fwd: [jbosstools-commits] JBoss Tools SVN: r3757 - in trunk/hibernatetools/plugins/org.jboss.tools.hibernate.ui.view: src/org/jboss/tools/hibernate/ui/view/views and 1 other directory.]

[Max Rydahl Andersen]

Hi Michael,

Great that you are trying to fix JBIDE-611.

Got some comments on that:

1)  Any way that this could be done in the hibernate tools plugin 
instead of the unrelated diagram plugin ? (I don't see you are using any 
  new plugins for this so should be in the core of hibernate tools imo)

2) Please don't use bogus id's in our plugin.xml like: com.xyz.runXYZ, 
it should be something stable and resembling the other id's.

3) This code looks like it is assuming everything are done in mapping 
files and with a cfg.xml file; is that correct ?  What  about annotated 
classes?

4) you have copied a large chunk of code from hibernate tools plugin to 
locate the default project; why don't you use the existing code for that ?

/max
-------------- next part --------------
An embedded message was scrubbed...
From: jbosstools-commits at lists.jboss.org
Subject: [jbosstools-commits] JBoss Tools SVN: r3757 - in
	trunk/hibernatetools/plugins/org.jboss.tools.hibernate.ui.view:
	src/org/jboss/tools/hibernate/ui/view/views and 1 other directory.
Date: Fri, 21 Sep 2007 11:19:19 -0400
Size: 15455
Url: http://lists.jboss.org/pipermail/jbosstools-dev/attachments/20070922/1d899c24/attachment.eml