[jbosstools-dev] [Fwd: [jbosstools-commits] JBoss Tools SVN: r3756 - trunk/jst/plugins/org.jboss.tools.jst.web.ui/src/org/jboss/tools/jst/web/ui/action/server.]

[Max Rydahl Andersen]

Hi slava,

cool this touch feature is being added.

A couple of questions though:

1) Why is both the manifest.mf and web.xml being touched for ear 
deployment ? The war is inside the ear so just touching the ear should 
be enough; doesn't touching both trigger risk a double-restart ?

2) We should also check that if the war is inside an ear the ear 
descriptor should be touched; and if not in an ear the war descriptor 
should be touched. Do we do that already ?

3) The code scans *all* project files multiple times - that can't be 
very efficient for large projects.

Since these projects knows where their descriptors are why are we 
scanning for them ?

4) btw. seam-gen uses this for ear's:

	<target name="restart" depends="explode" description="Restart the 
exploded archive">
		<touch file="${ear.deploy.dir}/META-INF/application.xml"/>
	</target>

Why did you choose manifest.mf for ear ?

Thanks,
/max
-------------- next part --------------
An embedded message was scrubbed...
From: jbosstools-commits at lists.jboss.org
Subject: [jbosstools-commits] JBoss Tools SVN: r3756 -
	trunk/jst/plugins/org.jboss.tools.jst.web.ui/src/org/jboss/tools/jst/web/ui/action/server.
Date: Fri, 21 Sep 2007 10:19:43 -0400
Size: 9597
Url: http://lists.jboss.org/pipermail/jbosstools-dev/attachments/20070922/4276d62d/attachment.eml