[jbosstools-dev] Re: Need to fix a blocker issue: ESB project wizard can not work with WTP 3.03

[Denny Xu]

Max Rydahl Andersen wrote:
> Hi Denny,
>
> Ok - so this looks like I feared.
>
> IMO It is ok for WTP to *add* methods for better behavior but it is
> not ok to change an existing public api/methods behavior.
>
> At least not with a really really good reason - so we need to find what
> their reason was if any.
>
> Let me know when you have created the bug so we can make WTP-dev aware 
> of it.
The bug is reported:  https://bugs.eclipse.org/bugs/show_bug.cgi?id=257470

Denny
>
> /max
>
>> John Graham wrote:
>>> A couple of questions:
>>>
>>> * Will fixing this for 3.0.3 mean that the wizard will no longer 
>>> work in
>>> earlier versions? If so, then we need to carefully document this, since
>>> users will not expect this large difference between 3.0.1/2 --> 3.0.3
>>>
>> Unfortunately, it will not work in earlier versions :-( .
>>> * Are we using the same functionality in other JBT wizards? If so, are
>>> they broken or have they avoided the issue somehow (if avoided, this
>>> might suggest a backward compatible work-around?)
>>>
>> Other JBT project may not have the same issue because those project 
>> are based on Dynamic Web Project,
>>  so the sort of creating a Virtualcomponent work is done by Dynamic 
>> Web project,  WTP changes all their
>>  creating Virtualcomponent way by using the new method in WTP 3.03 
>> when creating a new Web project or J2ee project.
>>
>> The issue is:  in early WTP versions,  it should use the following 
>> way to create the VirtualComponent:
>> final IVirtualComponent c = ComponentCore.createComponent(project);
>>
>> and in WTP 3.03, we have to do it by:  final IVirtualComponent c = 
>> ComponentCore.createComponent(project, false);
>> the *false* parameter is a flag that whether to check a configure 
>> file exist or not, in our scenario , it should not check.
>> and the *ComponentCore.createComponent(project, false) * method is 
>> not exist in early versions.
>> for now, the ComponentCore.createComponent(project) works as  
>> ComponentCore.createComponent(project, true),
>> if it can be changed to work as 
>> ComponentCore.createComponent(project, false), it will works and it's 
>> reasonable ,
>> I will raise a bug to wtp, if they can change their implementation, 
>> that would be good, if they wouldn't change, we have to try
>> to check if the componentCore has the method using refect way.
>>
>> Denny
>>
>>
>>> -- John
>>>
>>> On Wed, 2008-12-03 at 21:53 +0800, Denny Xu wrote:
>>>
>>>> Max Rydahl Andersen wrote:
>>>>
>>>>> Is this on *public* API ?
>>>>>
>>>>> If yes, we need to raise that to bugs.eclipse.org
>>>>>
>>>> yes, it's public API,  the changes break a already exist API, it 
>>>> should be a bug, I will report it to WTP.
>>>>
>>>> Denny
>>>>
>>>>> /max
>>>>>
>>>>>
>>>>>> Max Rydahl Andersen wrote:
>>>>>>
>>>>>>> Yes, WTP 3.0.3 is the target so needs fixing.
>>>>>>>
>>>>>>> What is causing the failure ?
>>>>>>>
>>>>>> It seems that WTP 3.03 has changed the implementation of 
>>>>>> ModuleCore when creating a VirtualComponent for a project, it 
>>>>>> overloads the "createComponent"  method in ComponentManager class 
>>>>>> and  we have to invoke the new overloaded method  to create  
>>>>>> VirtualComponent.
>>>>>>
>>>>>> Denny
>>>>>>
>>>>>>
>>>>>>> /max
>>>>>>>
>>>>>>>
>>>>>>>> Hi all
>>>>>>>>
>>>>>>>> When change the WTP to 3.03, the ESB project wizard doesn't 
>>>>>>>> work at all,  should I commit the changes to trunk .
>>>>>>>> here is the JIRA: https://jira.jboss.org/jira/browse/JBIDE-3333
>>>>>>>>
>>>>>>>> Denny
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>
>>>>>
>>>> _______________________________________________
>>>> jbosstools-dev mailing list
>>>> jbosstools-dev at lists.jboss.org
>>>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>>>>
>>>
>>>
>>
>
>
>