[jbosstools-dev] Central does not compile

[Max Andersen]

You did not have to rebuild all of jbosstools - just rebuild the parts that are most dependent on it. In this case central. 

Anyway - onwards to find a proper way to get stacks decoupled. 

/max (sent from my phone)


On 30/04/2013, at 09.43, Rob Stryker <rstryker at redhat.com> wrote:

> Reverting the patch was the correct solution. 
> 
> It is not always possible to rebuild *all* dependent components locally and run the test suites. That's what Jenkins is for. It'd take a very long time. I *did* rebuild all of base and run its tests though. Reverting the fix is the best solution there is. It's a smack in the face to the committer (me), which alerts me to fix my problem, and it also gets MASTER back in shape as fast as possible. 
> 
> I take full blame for the issue of course, but I do feel that asking me to build all of jbt before committing is a bit much. I should have just taken more time to review the change. 
> 
> In the future, also re-open whichever jira was the one that caused the error. You can see it in the commit log. 
> 
> Anyway, good work team. ... well, everyone except me ;) 
> 
> On 04/27/2013 01:05 PM, Alexey Kazakov wrote:
>> On 04/26/2013 08:07 PM, Max Andersen wrote:
>>> Alexey,
>>> 
>>> That sucks and should not happen. In such cases its ok to revert that commit and reopen the PR. I can't do it right now since I'm on the road. Feel free to do it.
>> Done.
>> 
>> 
>> 
>> 
>> 
>>> 
>>> /max (sent from my phone)
>>> 
>>> 
>>> On 26/04/2013, at 22.22, Alexey Kazakov <akazakov at exadel.com>            wrote:
>>> 
>>>> Guys, if you change any common code then please make sure that all the dependent components are built locally w/o errors before pushing PRs to the upstream repo.
>>>> It seems that https://github.com/jbosstools/jbosstools-base/pull/93 broke central: https://issues.jboss.org/browse/JBIDE-14327
>>>> _______________________________________________
>>>> jbosstools-dev mailing list
>>>> jbosstools-dev at lists.jboss.org
>>>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>> 
>> 
>> 
>> _______________________________________________
>> jbosstools-dev mailing list
>> jbosstools-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
> 
> _______________________________________________
> jbosstools-dev mailing list
> jbosstools-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/jbosstools-dev/attachments/20130430/71656ff2/attachment.html