[jbosstools-dev] FEEDBACK REQUESTED: Using maven-dependency-plugin to download upstream requirements into your build / removing redundant skip*Requirements variables from parent pom

[Max Rydahl Andersen]

On 30 Nov 2015, at 21:55, Nick Boldt wrote:

> Looking in the 4.3.x and master branches, I can only see two poms with
> a reference to maven-dependency-plugin or generate-resources, both of
> which have their <skip>false</skip> set:
>
> ./plugins/org.jboss.tools.openshift.client/pom.xml
> ./plugins/org.jboss.tools.openshift.express.client/pom.xml
>
> So, how was your openshift build failing? Can you give details
> (console log, for example) on how `mvn clean install -DskipTests=true`
> failed?

yes, the build did not work when you run with -DskipTests=true.

I have to run it with just "mvn clean install" to work, just doing "mvn 
clean install -DskipTests=true" resulted in failure to build related to 
the openshift java client updates.

anyway, lets just fix the issue that requires us to litter 
<skip>false</skip>
into components builds. Please.

/max

>
>
> On Thu, Nov 26, 2015 at 7:40 AM, Max Rydahl Andersen
> <manderse at redhat.com> wrote:
>> on this note - I just spent half the day figuring out why
>> jbosstools-openshift
>> was not building when I did "mvn clean install -DskipTests=true".
>>
>> Turns out I'm hit with this exact issue - that skipTest is for reason 
>> I
>> never understood
>> is used to turn off download for testing dependencies by turning of 
>> download
>> of all dependencies.
>>
>> We need to stop adding workaround for this into our projects and 
>> instead
>> have those few projects
>> that have large dependencies to use another mechanism to turn of 
>> download.
>>
>> /max
>>
>> Only one I don't know about is swtbot.test.skip.
>>
>> The others I don't see how to remove nor why since they all play a 
>> part.
>>
>> This sounds more like should fix how the skip's works rather than 
>> remove
>> them.
>>
>> The issue in JBIDE-15330 seem to because of the many time pointed out 
>> bad
>> assumption that skipTest
>> should mean you don't want dependencies to be downloaded.
>>
>> Reported here https://issues.jboss.org/browse/JBIDE-15332 in 2013.
>>
>> The issue is <skipRequirements>${skipTests}</skipRequirements>
>> and then skipRequirements are used to disable all basic dependency 
>> fetching
>> which is simply a wrong/bad assumption.
>>
>> /max
>>
>> If your project needs to download upstream libraries/runtimes/jars
>> using something like maven-dependency-plugin, and you have not set
>> <skip>false</skip> for those plugins' builds, eg.,
>> https://github.com/jbosstools/jbosstools-livereload/pull/54/ you
>> should do so.
>>
>> This is because I'd like to remove some of the obsolete skip*
>> variables we have in the parent pom, and you don't want your builds 
>> to
>> fail when skipping tests, as livereload used to before
>> https://issues.jboss.org/browse/JBIDE-15330 was fixed.
>>
>> Here are all the skip-related variables in our parent pom [1]:
>>
>> <swtbot.test.skip>true</swtbot.test.skip>
>> <skipRequirements>${skipTests}</skipRequirements>
>> <skipPrivateRequirements>true</skipPrivateRequirements>
>> <skipTestsWithPrivateRequirements>${skipPrivateRequirements}</skipTestsWithPrivateRequirements>
>> and
>> skipTestsOrITests (which is true when skipTests or skipITests is 
>> true).
>>
>> [1]
>> https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml
>>
>> Which of those are no longer used, that can be safely removed? Are
>> skipTestsWithPrivateRequirements and skipRequirements used for the
>> same purposes as skipITests?
>>
>> Thanks,
>>
>> --
>> Nick Boldt :: JBoss by Red Hat
>> Productization Lead :: JBoss Tools & Dev Studio
>> http://nick.divbyzero.com
>>
>> ________________________________
>>
>> jbosstools-dev mailing list
>> jbosstools-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>>
>> /max
>> http://about.me/maxandersen_______________________________________________
>> jbosstools-dev mailing list
>> jbosstools-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>>
>> /max
>> http://about.me/maxandersen
>
>
>
> -- 
> Nick Boldt :: JBoss by Red Hat
> Productization Lead :: JBoss Tools & Dev Studio
> http://nick.divbyzero.com


/max
http://about.me/maxandersen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/jbosstools-dev/attachments/20151201/4b5970e9/attachment.html