[jbosstools-dev] FEEDBACK REQUESTED: Using maven-dependency-plugin to download upstream requirements into your build / removing redundant skip*Requirements variables from parent pom

[Martin Malina]

We (QA) used to use swtbot.test.skip in the past, but we abandoned it earlier this year:
https://github.com/jbosstools/jbosstools-integration-tests/commit/517bc6938bb1cbe616a2abeb25b383da3d6c4dda

So we're fine with removing it. But I don't know if some developers use it for their tests in their repos.

-Martin


> On 26. 11. 2015, at 0:00, Max Rydahl Andersen <manderse at redhat.com> wrote:
> 
> Only one I don't know about is swtbot.test.skip.
> 
> The others I don't see how to remove nor why since they all play a part.
> 
> This sounds more like should fix how the skip's works rather than remove them.
> 
> The issue in JBIDE-15330 seem to because of the many time pointed out bad assumption that skipTest 
> should mean you don't want dependencies to be downloaded.
> 
> Reported here https://issues.jboss.org/browse/JBIDE-15332 <https://issues.jboss.org/browse/JBIDE-15332> in 2013.
> 
> The issue is <skipRequirements>${skipTests}</skipRequirements>
> and then skipRequirements are used to disable all basic dependency fetching
> which is simply a wrong/bad assumption.
> 
> /max
> 
> If your project needs to download upstream libraries/runtimes/jars
> using something like maven-dependency-plugin, and you have not set
> <skip>false</skip> for those plugins' builds, eg.,
> https://github.com/jbosstools/jbosstools-livereload/pull/54/ <https://github.com/jbosstools/jbosstools-livereload/pull/54/> you
> should do so.
> 
> This is because I'd like to remove some of the obsolete skip*
> variables we have in the parent pom, and you don't want your builds to
> fail when skipping tests, as livereload used to before
> https://issues.jboss.org/browse/JBIDE-15330 <https://issues.jboss.org/browse/JBIDE-15330> was fixed.
> 
> Here are all the skip-related variables in our parent pom [1]:
> 
> <swtbot.test.skip>true</swtbot.test.skip>
> <skipRequirements>${skipTests}</skipRequirements>
> <skipPrivateRequirements>true</skipPrivateRequirements>
> <skipTestsWithPrivateRequirements>${skipPrivateRequirements}</skipTestsWithPrivateRequirements>
> and
> skipTestsOrITests (which is true when skipTests or skipITests is true).
> 
> [1] https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml <https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml>
> Which of those are no longer used, that can be safely removed? Are
> skipTestsWithPrivateRequirements and skipRequirements used for the
> same purposes as skipITests?
> 
> Thanks,
> 
> -- 
> Nick Boldt :: JBoss by Red Hat
> Productization Lead :: JBoss Tools & Dev Studio
> http://nick.divbyzero.com <http://nick.divbyzero.com/>
> jbosstools-dev mailing list
> jbosstools-dev at lists.jboss.org <mailto:jbosstools-dev at lists.jboss.org>
> https://lists.jboss.org/mailman/listinfo/jbosstools-dev <https://lists.jboss.org/mailman/listinfo/jbosstools-dev>
> /max
> http://about.me/maxandersen <http://about.me/maxandersen>_______________________________________________
> jbosstools-dev mailing list
> jbosstools-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jbosstools-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/jbosstools-dev/attachments/20151201/d83c5af4/attachment-0001.html