[jbosstools-dev] Why do we include both Jetty 9.2.10 and 9.2.9 in our target platforms?

[Denis Golovin]

I did update for jetty 9.2.10 in tests to fix test errors, but new version
was introduced by this commit
https://github.com/jbosstools/jbosstools-target-platforms/commit/da4aeb27d8941ff4196d18f561713737836513d2
.

Not sure what happened with jetty mirroring, but probably the mirror was
done from jetty p2 repo, which had newer version than mars M7 release.

This difference between versions in mars and jbt tp and the fact help in
eclipse lock down to jetty 9.2.9 leads to both included into jbds installer.

jetty bundles are not singletons and that fact we have two versions at the
same time should not be a problem., eclipse help will still use 9.2.9 and
we will use 9.2.10.



On Tue, Jul 21, 2015 at 5:53 AM, Max Rydahl Andersen <manderse at redhat.com>
wrote:

> On 21 Jul 2015, at 11:57, Ilya Buziuk wrote:
>
>  AFAIK we used to ship 9.2.9 bundles for CordovaSim / Livereload.
>> There is also a test that track changes in TP and fails once Mars TP has
>> jetty updates ( it has some Jetty 9 bundles (via other dependencies))  -
>>
>> https://github.com/jbosstools/jbosstools-aerogear/blob/master/cordovasim/tests/org.jboss.tools.cordovasim.eclipse.test/src/org/jboss/tools/corodvasim/eclipse/test/JettyBundlesTest.java#L33
>> So, once the test fails (Mars TP has been updated) we also need to update
>> jetty in our TP.
>> Denis fixed the test and AFAIK now CordovaSim uses 9.2.10 bundles, but we
>> also need to make clean up in TP. So, I guess we need to simply remove
>> 9.2.9 from TP if LiveReload is fine with it
>>
>
> Problem is that Help in eclipse seem to lock down on jetty 9.2.9 thus:
>
> a) why are they locked down so close
>
> b) why did we need jetty 9.2.10 if 9.2.9 is what Mars is locked
> to/preferring to use ?
>
> Denis - you seem to have done parts of the 9.2.10 move - any idea ?
> /max
>
>
>
>>
>> On Mon, Jul 20, 2015 at 11:00 PM, Max Rydahl Andersen <
>> manderse at redhat.com>
>> wrote:
>>
>>
>>>  Our target platforms contain multiple versions of Jetty.
>>>>
>>>> What's in Jetty 9.2.10 that we need that's not in 9.2.9?
>>>>
>>>
>>> Ilya do you know what the diff is ?
>>>
>>>  Could we push
>>>> on Eclipse to bump up to depending on 9.2.10 (or at least widening
>>>> their
>>>> version requirement range) for Mars SR1?
>>>>
>>>
>>> You should open a bugzilla if you find something that is too narrow.
>>>
>>> jira asking for jetty 9 is at
>>> https://issues.jboss.org/browse/JBIDE-19497 where I said there was risk
>>> for version mismatch
>>> but Mickael stated there wouldn't be one. I guess that changed ? (I
>>> don't know more than what are in those jiras)
>>>
>>> /max
>>>
>>>  Ref: https://issues.jboss.org/browse/JBIDE-20313
>>>>
>>>> --
>>>> Nick Boldt :: JBoss by Red Hat
>>>> Productization Lead :: JBoss Tools & Dev Studio
>>>> http://nick.divbyzero.com
>>>> _______________________________________________
>>>> jbosstools-dev mailing list
>>>> jbosstools-dev at lists.jboss.org
>>>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>>>>
>>>
>>>
>>> /max
>>> http://about.me/maxandersen
>>> _______________________________________________
>>> jbosstools-dev mailing list
>>> jbosstools-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>>>
>>>
>>
>>
>> --
>> Best Regards,
>> Ilya Buziuk
>>
>
>
> /max
> http://about.me/maxandersen
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/jbosstools-dev/attachments/20150721/79e57d4d/attachment-0001.html