[jbosstools-dev] ACTION REQUIRED: Can we move up to requiring JUnit 4.12 instead of 3.8? (4.50.0.Beta1-SNAPSHOT target platform w/ Mars M7)

[Denis Golovin]

You are correct, I did not. But error you mention is exactly what I have
fixed :)
But you probably right about migration to exact version of JUnit, because
if we declare range [3.8.0,5.0.0) for instance, it means we have to in some
way check 3.8.0 works as well, since we are not going to do that lets move
up to [4.12.0, 5.0.0) or even to open range starting from 4.12.0.

Denis

On Fri, May 22, 2015 at 9:30 AM, Nick Boldt <nboldt at redhat.com> wrote:

> You must not have run all the tests. coretests failed in Jenkins with
> this error:
>
> [ERROR]   Missing requirement:
> org.jboss.tools.batch.test.feature.feature.group
> 1.7.0.Beta1-v20150520-2011-B779 requires 'org.junit [3.8.1,4.0.0)' but
> it could not be found
>
>
> https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-build-sites.aggregate.coretests-site_master/4370/console
>
> Everything else is NOT fine. :D
>
> On 05/22/2015 12:09 PM, Denis Golovin wrote:
> > i tested full build yesterday and only javaee requires to update some
> > features (see https://github.com/jbosstools/jbosstools-javaee/pull/339)
> > Everything else is fine.
> >
> > On Fri, May 22, 2015 at 9:05 AM, Max Rydahl Andersen
> > <manderse at redhat.com <mailto:manderse at redhat.com>> wrote:
> >
> >     Your junit tests does not use anything that requires junit 4 ?
> >
> >     You should at least set the minimum boundary.
> >
> >     /max
> >     http://about.me/maxandersen
> >
> >
> >      > On 22 May 2015, at 17:17, George Gastaldi <ggastald at redhat.com
> >     <mailto:ggastald at redhat.com>> wrote:
> >      >
> >      > Another hint as Nick proposed is to remove the JUnit version
> >     constraint.
> >      > I'm doing that for Forge
> >      >
> >      >> On 05/22/2015 12:16 PM, Nick Boldt wrote:
> >      >> Some PRs to consider, which fix MANIFEST.MF and feature.xml
> files to
> >      >> depend on 4.12.0 instead of 3.8.x:
> >      >>
> >      >> https://github.com/jbosstools/jbosstools-forge/pull/140
> >      >> https://github.com/jbosstools/jbosstools-vpe/pull/311
> >      >> https://github.com/jbosstools/jbosstools-portlet/pull/33
> >      >> https://github.com/jbosstools/jbosstools-jst/pull/487
> >      >> https://github.com/jbosstools/jbosstools-javaee/pull/340
> >      >> https://github.com/jbosstools/jbosstools-hibernate/pull/73
> >      >> https://github.com/jbosstools/jbosstools-bpel/pull/25
> >      >> https://github.com/jbosstools/jbosstools-base/pull/407
> >      >>
> >      >> I've omitted changing anything in poms that declare a MAVEN
> >     dependency
> >      >> to JUnit 3.8, since that should still be resolved by Maven (not
> >     by p2).
> >      >>
> >      >> Lookin' at you, Central (Maven), JavaEE (CDI & JSF), and VPE.
> >      >>
> >      >>> On 05/21/2015 09:20 PM, Nick Boldt wrote:
> >      >>> The following projects have plugins or features which depend on
> >     JUnit 3.8.
> >      >>>
> >      >>> Can they be changed to use JUnit 4.12, which is the version
> >     included in
> >      >>> the latest 4.50.0.Beta1-SNAPSHOT target platform and Mars M7?
> >      >>>
> >      >>> * base
> >      >>> * bpel
> >      >>> * central
> >      >>> * forge
> >      >>> * hibernate
> >      >>> * javaee
> >      >>> * jst
> >      >>> * portlet
> >      >>> * vpe
> >      >>>
> >      >>> Or do we need to find a way to include JUnit 3.8 as well as
> >     JUnit 4.12?
> >      >>>
> >      >>> Details here: https://issues.jboss.org/browse/JBIDE-19836
> >      >
> >      > _______________________________________________
> >      > jbosstools-dev mailing list
> >      > jbosstools-dev at lists.jboss.org
> >     <mailto:jbosstools-dev at lists.jboss.org>
> >      > https://lists.jboss.org/mailman/listinfo/jbosstools-dev
> >
> >     _______________________________________________
> >     jbosstools-dev mailing list
> >     jbosstools-dev at lists.jboss.org <mailto:
> jbosstools-dev at lists.jboss.org>
> >     https://lists.jboss.org/mailman/listinfo/jbosstools-dev
> >
> >
> >
> >
> > _______________________________________________
> > jbosstools-dev mailing list
> > jbosstools-dev at lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/jbosstools-dev
> >
>
> --
> Nick Boldt :: JBoss by Red Hat
> Productization Lead :: JBoss Tools & Dev Studio
> http://nick.divbyzero.com
> _______________________________________________
> jbosstools-dev mailing list
> jbosstools-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jbosstools-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/jbosstools-dev/attachments/20150522/4a9dfe16/attachment-0001.html