[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-982) deleting a seam runtime gives no warning/adjustment if projects use it (and projects fallback to chosing a default one which might be wrong)

[Denis Golovin (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBIDE-982?page=comments#action_12381306 ] 
            
Denis Golovin commented on JBIDE-982:
-------------------------------------

I've added org.jboss.tools.seam.core.prefs preferences to ejb and test projects. 

we should handle right for several cases:
1. For seam web project in war and ear configurations

Seam Dynamic Web project is parent for EJB and test project and that mean and all project for this case should have the same seam runtime.
Seam Dynamic Web project has following preferences:

#Mon Oct 08 18:15:32 PDT 2007
action.package=org.domain.seam01.session
eclipse.preferences.version=1
model.package=org.domain.seam01.entity
seam.ear.project=seam01-ear
seam.ejb.project=seam01-ejb
seam.project.connection.profile=DefaultDS
seam.project.deployment.type=ear
seam.runtime.name=seam-1.2.AP
seam.test.project=seam01-test
test.package=org.domain.seam01.test

it contains all information about project that is used in seam related wizards.

EAR and test project have simple preferences with just a link to parent projects

#Mon Oct 08 18:15:32 PDT 2007
eclipse.preferences.version=1
seam.parent.project=seam01

that situation should be handled correctly by SeamCore classes. SeamProject should load runtime name from parent project . That means Seam Settings Preferences page for EJB and test projects should not allow to change seam runtime and enable disable/seam support. It should just show Seam support checkbox checked and disable, sem runtime selection combo should have seam runtime from parent project as value and also disabled. Property page should post  message that seam runtime can be changed on parent project ('seam01' in current example).

Project preference page for parent Dynamic web project doesn't allow to enable disable Seam support also, but it allows to change seam runtime. Changing runtime on Seam Dynamic Web project means that Seam Runtime for depended project is also changed. So SeamProject should handle it.

The simplest solution just don't show Seam Settings preference page for dependent EJB and test projects.

2. Standalone seam project  - any java nature project that have no seam core preferences. When Seam Support selected it should just add seam runtime in preferences. And seam support for that kind project can be enabled disabled anytime.

#Mon Oct 08 18:15:32 PDT 2007
seam.runtime.name=seam-1.2.AP

3. If there is no Seam Runtime with name in seam.runtime.name preference SeamCore should create error marker for main and related projects. That runtime 'Runtime name' doesn't exists, and propose create seam runtime on Seam preference page.

> deleting a seam runtime gives no warning/adjustment if projects use it (and projects fallback to chosing a default one which might be wrong)
> --------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-982
>                 URL: http://jira.jboss.com/jira/browse/JBIDE-982
>             Project: JBoss Tools
>          Issue Type: Bug
>          Components: Seam
>    Affects Versions: 2.0.0.Beta3
>            Reporter: Max Andersen
>         Assigned To: Viacheslav Kabanovich
>             Fix For: 2.0.0.CR1
>
>
> shouldn't there be a warning + a possible to change them to something else + if a runtime does not exist for a project it should not fall back to something default if there explicitly is set a different one.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira