[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-1912) ctrl+1 Find seam references should tell what it will actually search for

[Victor Rubezhny (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBIDE-1912?page=comments#action_12403152 ] 
            
Victor Rubezhny commented on JBIDE-1912:
----------------------------------------

Max, You wrote: ...except know it seems that it actually does the search to determine if the query would result in something...won't that cost alot of performance/waittime on larger projects ?

I don't think that it would cost much more for the larger projects... I just used the project variables (which are already collected) to decide if the text under the cursor starts with some variable name. If it is true the search will be continued for the variable declaration/references. Otherwise search will not be performed.

You wrote: e.g. it shows up on identity.getUsername(); but not on userName.length(); ....how can it know that userName will not return a result without doing the actual search first ? 

In jbide-509 we decided to search for the variable declarations/references, so for now it doesn't matters of the end of EL. The only starting part of EL (variable name) will be search for. 
jbide-1912 is to extend this to search for methods/properties of the Seam variable... I'm confused a little bit in what to display in this case, because it is to be searched thru the EL before I can display the real query is to be searched for... It was simple to calculate the display string while we're searching for the variables. Now it will be more difficult, but still realizable.

Here is a question on what shall I search.
For example: 

#{testEntityList.resultList.size}

if  the cursor is placed over the testEntityList I'll search for declaration of/references to testEntityList variable (this is how it works now), but...

if the cursor is placed over the resultList I'll search for resultList property or method declarations/references for any component in the project. (java search does in the same way). It's not realized now.

But what shall I search if the cursor is placed over the size property or method? Shall I still search for size property or method declarations/references for any component in the project? Or shall I search for resultList property/method?











> ctrl+1 Find seam references should tell what it will actually search for
> ------------------------------------------------------------------------
>
>                 Key: JBIDE-1912
>                 URL: http://jira.jboss.com/jira/browse/JBIDE-1912
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Seam
>            Reporter: Max Andersen
>         Assigned To: Victor Rubezhny
>             Fix For: 2.1
>
>
> today Ctrl+1 just says "Find Seam references" or "Find Seam declarations"
> It would be more helpfull if it could say "Find Seam references for 'authenticator'" so users would know what it is actually trying to search for.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira