[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-1912) ctrl+1 Find seam references should tell what it will actually search for

[Max Andersen (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBIDE-1912?page=comments#action_12403288 ] 
            
Max Andersen commented on JBIDE-1912:
-------------------------------------

About performance: "I just used the project variables (which are already collected)" ....these variables are (or at least should be done in the background) thus it might not be available since if it blocks the ui for large projects it will be a big showstopper. The initial quickfix popup should not require large calculations and if it requires the seam builder to have completed it will block the creation of that popup - and that is bad plugin behavior.

About types then I can't recognize that java search search for all calsses with resultList. It looks for references to the resultList variable/method on the same type as testEntityList is.

So to be explicit here is what I think should happen in case of #{testEntity.resultList.size} declaration search
(note: not all of these needs to be implemented, we should do them in steps/ that makes sense)

testEntity -> declarations with the same name (e.g. testEntity) and if we actually know what specific "testEntity" it is pointing to (e.g. it is a local variable used in a loop) then it should only list the specific declarations (e.g. where the variable is declared in the start of the loop)

testEntity.resultList -> search from declarations of testEntity and find its type (might be multiple types) and then scan those types for possible things that resultList can be declared as (e.g. method or resultList or field resultList)

testEntity.resultList.size() -> find the type(s) of testEntity, find the things that can be resultList on testEntity (method, field, key in map) and then scan for size() method on those possible types. 

Similar rules can be defined for references.

What I suggest you/we do is to define a list of possible combiations of xhtml, components.xml and java that illustrates all the possible way of having multiple types and references and express that in unittests that we can use to verify this.

> ctrl+1 Find seam references should tell what it will actually search for
> ------------------------------------------------------------------------
>
>                 Key: JBIDE-1912
>                 URL: http://jira.jboss.com/jira/browse/JBIDE-1912
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Seam
>            Reporter: Max Andersen
>         Assigned To: Victor Rubezhny
>             Fix For: 2.1
>
>
> today Ctrl+1 just says "Find Seam references" or "Find Seam declarations"
> It would be more helpfull if it could say "Find Seam references for 'authenticator'" so users would know what it is actually trying to search for.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira