[jbosstools-issues] [JBoss JIRA] Created: (JBIDE-5351) Remove unnecessary setSmooksConfig method on the RuntimeMetadata class

Tom Fennelly (JIRA) jira-events at lists.jboss.org
Wed Dec 2 05:22:29 EST 2009


Remove unnecessary setSmooksConfig method on the RuntimeMetadata class
----------------------------------------------------------------------

                 Key: JBIDE-5351
                 URL: https://jira.jboss.org/jira/browse/JBIDE-5351
             Project: Tools (JBoss Tools)
          Issue Type: Bug
          Components: smooks
            Reporter: Tom Fennelly
            Assignee: Tom Fennelly
             Fix For: 3.1.0.CR1


The additional code in this method (cut & paste of existing version) is just opening a FileInputStream on the smooks configFile (and not closing) if the new InputStream param is null.  Not really sure why that was added??

Of course the potential file handle leak is the big issue here!!

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the jbosstools-issues mailing list