[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-5351) Remove unnecessary setSmooksConfig method on the RuntimeMetadata class

[Tom Fennelly (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-5351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12497669#action_12497669 ] 

Tom Fennelly commented on JBIDE-5351:
-------------------------------------

OK... sorry.... I missed something here on the first look... it passes the stream on down.

Still... with the exception of the few additional lines... the rest of the code is cut & paste duplication.

> Remove unnecessary setSmooksConfig method on the RuntimeMetadata class
> ----------------------------------------------------------------------
>
>                 Key: JBIDE-5351
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-5351
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: smooks
>            Reporter: Tom Fennelly
>            Assignee: Tom Fennelly
>             Fix For: 3.1.0.CR1
>
>
> The additional code in this method (cut & paste of existing version) is just opening a FileInputStream on the smooks configFile (and not closing) if the new InputStream param is null.  Not really sure why that was added??
> Of course the potential file handle leak is the big issue here!!

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira