[jbosstools-issues] [JBoss JIRA] Closed: (JBIDE-5351) Remove unnecessary setSmooksConfig method on the RuntimeMetadata class

[Tom Fennelly (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBIDE-5351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom Fennelly closed JBIDE-5351.
-------------------------------

    Fix Version/s: 3.1.0.GA
       Resolution: Done


branches/jbosstools-3.1.0.RC1: 18978
trunk: 18979

> Remove unnecessary setSmooksConfig method on the RuntimeMetadata class
> ----------------------------------------------------------------------
>
>                 Key: JBIDE-5351
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-5351
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: smooks
>            Reporter: Tom Fennelly
>            Assignee: Tom Fennelly
>             Fix For: 3.1.0.CR1, 3.1.0.GA
>
>
> The additional code in this method (cut & paste of existing version) is just opening a FileInputStream on the smooks configFile (and not closing) if the new InputStream param is null.  Not really sure why that was added??
> Of course the potential file handle leak is the big issue here!!

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira