[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-4962) Change toolbar icons design in friendly way to Eclipse UI

[Denis Maliarevich (JIRA)]

    [ https://jira.jboss.org/jira/browse/JBIDE-4962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12488978#action_12488978 ] 

Denis Maliarevich commented on JBIDE-4962:
------------------------------------------

ToolBar items were remade: now they correspond to eclipse Actions, their implementation in code became simpler, icons were updated.

Eclipse's "org.eclipse.ui.menus" extention point allows adding items to main eclipse toolbar, view's toolbar, custom views, but not to custom place in the editor. Also there were found class casting errors while implementing custom ContributionItem and adding it to the toolbar. So it wasn't very smooth and quick as I supposed earlier. Thus toolbar item were implemented as Actions with standard eclipse appearance and behaviour.

But, if there is a real need in setting up menu and toolbar items in the plugin.xml with standard extention points(commands, handlers, ui.menus, menuContributions), it could be done later as a separate task.

> Change toolbar icons design in friendly way to Eclipse UI
> ---------------------------------------------------------
>
>                 Key: JBIDE-4962
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-4962
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Visual Page Editor core
>    Affects Versions: 3.1.0.M4
>            Reporter: Yura Zhishko
>            Assignee: Denis Maliarevich
>            Priority: Minor
>         Attachments: screenshot-1.jpg
>
>
> ToolBar items doesn't correspond to Eclipse UI concept. All of this buttons should have a tooltip starting with word "Show", for example "Show selection tag bar". And they should be pressed if  "Show..." action is activated (screenshot-1). 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira