[jbosstools-issues] [JBoss JIRA] Resolved: (JBIDE-5501) Move AS support for specific facets out of AS ?

[Rob Stryker (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBIDE-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rob Stryker resolved JBIDE-5501.
--------------------------------

    Resolution: Rejected


This is a hard issue but I think I'm going to reject it. We tried once before just returning jars targeted to specific facets, but that meant each time a user wanted a new jar on the classpath, he'd need to enable that facet. For some of these things, for some internal jboss libraries, there are no facets available.

So we settled on the "include everything". Now this include everything strategy doesn't mean that AS Tools needs to know about every other participant. But it *does* mean they have to know what they are including.  So if I'm returning some portal jars, that means I should know I'm returning portal jars and if I'm asked if I'm returning portal jars I should reply that I am indeed. 

This is so that the "Server-provided runtimes" portion of the wizard works properly. If I claim ignorance to all facets coming in, and let others do  it, then the "server provided runtimes" feature doesn't work at all. Users won't be able to click "let the server provide the runtimes" because my server / runtime provider will claim I don't know those facets. 

So ultimately this is why I split out the as.wtp code. The as.wtp code would be code that would be more of a framework WTP-style, which other projects (ESB etc) can depend on in order to base their common / facet projects. 

The rest of AS tools is the deployment API and comes a step above. So basically the dependency tree looks like My Server Tools knows about (but doesn't depend on) ESB, and ESB *depends* on the as.wtp.core/ui code to set up their project. 

If we think as.wtp should be separated out into some type of common framework, that makes sense too. But moving the facet jar dependency stuff right now is not correct. It's being done mostly correctly as it is.  (It could use a bit of cleanup but it should definitely stay in AS Tools)

> Move AS support for specific facets out of AS ?
> -----------------------------------------------
>
>                 Key: JBIDE-5501
>                 URL: https://jira.jboss.org/jira/browse/JBIDE-5501
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: JBossAS
>            Reporter: Max Rydahl Andersen
>            Assignee: Rob Stryker
>            Priority: Optional
>             Fix For: 3.1.1, 3.2.next
>
>
> Looking at JBIDE-5229, is it not possible to move such support *outside* of AS module and let it be defined by the esb module or some integration module ? Or should as.core really have *all* knowledge and create a kind of logical circular dependency ? ESB needs AS, but AS needs ESB too ?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira