[jbosstools-issues] [JBoss JIRA] Commented: (JBIDE-6652) Implement ModeShape capability/activity to enable/disable ModeShape functionality

Dan Florian (JIRA) jira-events at lists.jboss.org
Thu Jul 29 12:20:49 EDT 2010


    [ https://jira.jboss.org/browse/JBIDE-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12541907#action_12541907 ] 

Dan Florian commented on JBIDE-6652:
------------------------------------

Instead of using Eclipse's Capabilities/Activities framework I believe Max, Brian, and I have agreed to use the visibility and enablement criteria available through a menu extension definition found in the plugin.xml. This extension definition should only allow the ModeShape submenu to appear in context menus when at least one ModeShape server has been configured by the user. So if a user has not configured at least one ModeShape server than they would never see the submenu. I have this working locally by implementing the "org.eclipse.ui.menus" as Max had suggested.

I believe the idea of also having the ability to turn on/off the ModeShape menu on a per-project basis was never resolved. I still believe once a user defines a ModeShape server they will want the ability to publish resources to that server from any project. I know others disagree with that. Remember, we are only talking about one additional item in the popup menu as the ModeShape items are contained within a ModeShape submenu. I believe we should wait and see what the user-base/community thinks before adding this type of limitation.

> Implement ModeShape capability/activity to enable/disable ModeShape functionality
> ---------------------------------------------------------------------------------
>
>                 Key: JBIDE-6652
>                 URL: https://jira.jboss.org/browse/JBIDE-6652
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: modeshape
>    Affects Versions: 3.2.0.M1
>            Reporter: Brian Fitzpatrick
>            Assignee: Dan Florian
>             Fix For: 3.2.x
>
>         Attachments: JBIDE-6652.patch
>
>
> As we discussed on the phone, the use of Capabilities/Activities in Eclipse might be a good way to handle the "Always On" aspect of the ModeShape menus in JBoss Tools. For some reason, this functionality is labeled as "Capabilities" in Eclipse Preferences, but the actual extension point is "org.eclipse.ui.activities" and called Activities in the API documentation. Go figure.
> That said, it's very simple to implement. I'll attach a patch with the suggested tweaks to plugin.xml and plugin.properties. But this should address Max's issues with the ModeShape menus appearing on all folders and files and be easy to add to the documentation. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        


More information about the jbosstools-issues mailing list