[jbosstools-issues] [JBoss JIRA] (JBIDE-11487) cleanup and align openshift settings exposed to users

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688543#comment-12688543 ] 

Rob Stryker commented on JBIDE-11487:
-------------------------------------

> I can no longer edit the deployments folder.

As per your comment, deployments folder has been moved into the project. Your comment leading to this behaviour was "so the only thing the server needs to keep track of is deployProject".  At this point, editing has not been enabled via the editor, since getting the editor to make workspace changes will take a bit of work. 

> The remote does not seem to be used as the key to allow for multiple ones as discussed previously.

I'm not sure exactly what you're asking here, however, as per the same comment, the 'remote' was moved into the project. Again, what was requested was:  "so the only thing the server needs to keep track of is deployProject"

If you'd like to keep this opened and have me change this behavior, and move both deployFolder and remote back into the server, I can do that.  
                
> cleanup and align openshift settings exposed to users
> -----------------------------------------------------
>
>                 Key: JBIDE-11487
>                 URL: https://issues.jboss.org/browse/JBIDE-11487
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>            Reporter: Max Rydahl Andersen
>            Assignee: Rob Stryker
>            Priority: Critical
>             Fix For: 3.3.0.Beta3
>
>
> From JBIDE-10527 I see that the following keys are stored in application servers:
> org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationId="769fbce4ec324292938a7aca2d7cbb69" 
> org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationName="app9" 
> org.jboss.tools.openshift.express.internal.core.behaviour.Domain="yourDomainHere" 
> org.jboss.tools.openshift.express.internal.core.behaviour.ExpressMode="publishSource" 
> org.jboss.tools.openshift.express.internal.core.behaviour.Username="username at example.com" 
> org.jboss.tools.openshift.express.internal.core.behaviour.binary.deployProject="app9"
> Two problems here:
> 1) the use of internal package names as base of the key - why is this not just openshift.<key> used as user visible setting ? Only if its something truly jboss tools specific could I see a reason to use a packagename, but still then not use internal since this key by the fact being stored in users settings are public and non-internal.
> 2) I think the project it self should be where applicationid, domain and usernme should be stored so the only thing the server needs to keep track of is deployProject and expressmode (if that is at all relevant anymore?)
> When creating servers you just then point to the project and get the info or select an application + project and the settings gets stored back on the project.
> That could be stored in .settings and be made available for tooling outside AS server integration. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira