[jbosstools-issues] [JBoss JIRA] (JBIDE-11487) cleanup and align openshift settings exposed to users

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688558#comment-12688558 ] 

Max Rydahl Andersen commented on JBIDE-11487:
---------------------------------------------

Rob:

As we discussed during triage and as was commented by your suggestion:

"Key of on remote name so you can have different git repo destinations"

Thats what we agreed on thus I was surprised you changed that.

And as discussed just because the settings are on the project does not mean the server editor can't change those settings, especially when no other way to edit them.

And still I cannot change the project for the server so it is just as rigid as before.

Thus I suggest as a minimum make the magic project editable so you can setup and configure the server.

And it was your suggestion to key of the remote so you did not limit it to one remote thus you would need to have both project and remote name on the server to know what to look up.


                
> cleanup and align openshift settings exposed to users
> -----------------------------------------------------
>
>                 Key: JBIDE-11487
>                 URL: https://issues.jboss.org/browse/JBIDE-11487
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>            Reporter: Max Rydahl Andersen
>            Assignee: Rob Stryker
>            Priority: Critical
>             Fix For: 3.3.0.Beta3
>
>
> From JBIDE-10527 I see that the following keys are stored in application servers:
> org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationId="769fbce4ec324292938a7aca2d7cbb69" 
> org.jboss.tools.openshift.express.internal.core.behaviour.ApplicationName="app9" 
> org.jboss.tools.openshift.express.internal.core.behaviour.Domain="yourDomainHere" 
> org.jboss.tools.openshift.express.internal.core.behaviour.ExpressMode="publishSource" 
> org.jboss.tools.openshift.express.internal.core.behaviour.Username="username at example.com" 
> org.jboss.tools.openshift.express.internal.core.behaviour.binary.deployProject="app9"
> Two problems here:
> 1) the use of internal package names as base of the key - why is this not just openshift.<key> used as user visible setting ? Only if its something truly jboss tools specific could I see a reason to use a packagename, but still then not use internal since this key by the fact being stored in users settings are public and non-internal.
> 2) I think the project it self should be where applicationid, domain and usernme should be stored so the only thing the server needs to keep track of is deployProject and expressmode (if that is at all relevant anymore?)
> When creating servers you just then point to the project and get the info or select an application + project and the settings gets stored back on the project.
> That could be stored in .settings and be made available for tooling outside AS server integration. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira