[jbosstools-issues] [JBoss JIRA] (JBIDE-12189) AS server adapters should check and provide way to fix or enough error info for users to get deployment working

[Rob Stryker (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rob Stryker resolved JBIDE-12189.
---------------------------------

    Resolution: Incomplete Description


The class ServerExtendedProperties and its subclasses provide a method named verifyServerStructure(), which is called in multiple places. Showing dialogs is not necessarily always possible, but the approved way of handling errors is to throw a CoreException with enough deteails such that the user can fix it on their own. 

At this point, a framework is in place, so unless you have specific use cases showing that this is insufficient, I'm going to have to reject this jira. Further issues related to this will be treated as a defect rather than "having some way to show...".  We already have some way to show what's wrong. Any future errors which are not being detected will be added in to this logic. 
                
> AS server adapters should check and provide way to fix or enough error info for users to get deployment working
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-12189
>                 URL: https://issues.jboss.org/browse/JBIDE-12189
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: JBossAS/Servers
>    Affects Versions: 3.3.0.Final
>         Environment: 
>            Reporter: Max Rydahl Andersen
>            Assignee: Rob Stryker
>
> As found in JBIDE-12188, JBIDE-9206 and JBIDE-9133 our server adapters keeps assuming everything is in a perfect condition.
> runtime directories, config files, temporary deploy folders etc. are assume to be present even though they might not be (users can have deleted them, servers have been created via API instead of UI etc.) 
> Server adapter should perform checkes for the things it need and if not there handle this error with proper info or creation of the files as needed or even show dialog saying "XYZ is missing/wrong, I can create it for you. Do you wish to create it ? Continue without or Cancel"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira