[jbosstools-issues] [JBoss JIRA] (JBIDE-12137) openshift server adapter should show progress of git push while running not in the end

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-12137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745417#comment-12745417 ] 

Andre Dietisheim commented on JBIDE-12137:
------------------------------------------

I mailed to jgit-dev:

on the 11th of January:
{quote}
if you git push via cmd line, you see the response getting in while the 
push is occurring.
I was wondering if one could achieve the same with jgit. I only saw 
PushResult#getMessage that I may only call once the push was executed. 
Transport#push, which returns the result, is blocking. Is there a way to 
achieve the same as in git cmd line? Do I miss something? I'd appreciate 
any pointers a lot. Thanks!
{quote}

on the 11th of January:
{quote}
I spotted the messages being written to MessageWriter while they come in from the backend.
In case of ssh-connection I see in SshPushConnection#doPush:

<snip>
if (capableSideBand) {
  int b = in.read();
</snip>

"in" is a SideBandInputStream which writes the messages to the MessageWriter in SideBandInputStream#doProgressLine.

<snip>
messages.write(msg);
</snip>


The current implementation of the PushProcess gets the messages (as concatenated string)  from the MessageWriter once the push is finished, PushProcess#execute:

<snip>
} finally {
  connection.close();
  res.addMessages(connection.getMessages());
}
</snip>

Assuming my understanding is correct, I'd make sure I can pass the messageWriter my very own OutputStream so that he can write the messages to it. That would allow me to show them in the Eclipse Console (or some dialog) as they come in.
{quote}

and Shawn Pearce, jgit PL confirmed the approach:

{quote}
The above is correct.
Right. You need to modify the transport API to support passing in an
OutputStream so JGit can send to your stream, rather than its buffer. 
{quote}
                
> openshift server adapter should show progress of git push while running not in the end
> --------------------------------------------------------------------------------------
>
>                 Key: JBIDE-12137
>                 URL: https://issues.jboss.org/browse/JBIDE-12137
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 3.3.0.Final
>            Reporter: Max Rydahl Andersen
>            Assignee: Andre Dietisheim
>             Fix For: 4.1.0.Alpha1
>
>
> Please bring back that the progress monitor shows the git progress instead of just showing console output in the end

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira