[jbosstools-issues] [JBoss JIRA] (JBIDE-16393) Fix/recover for bad usage of submodules in VPE

[Ilya Buziuk (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12937950#comment-12937950 ] 

Ilya Buziuk commented on JBIDE-16393:
-------------------------------------

{quote}
      before we work on what will be future master approach - please identify the commit in the personal Yahor Radtsevich repo we used for building branch.
{quote}
      *jbosstools-4.1.1.Final* - e498c091f79c140 ( JBIDE-15814 CordovaSim: Adding navigator.app.backHistory support )
{quote}
      Also there is no mention in those repos about their original source, license.
{quote}
      Actually, we had original source, licence info in the about.html in the org.jboss.tools.vpe.cordovasim.ripple plugin (the submodule directory)

[~mickael_istria], why not just push the submodule's code into the appropriate plugin?  Or to have submodules *not* in private repos?
                
> Fix/recover for bad usage of submodules in VPE
> ----------------------------------------------
>
>                 Key: JBIDE-16393
>                 URL: https://issues.jboss.org/browse/JBIDE-16393
>             Project: Tools (JBoss Tools)
>          Issue Type: Task
>          Components: browsersim, visual-page-editor-core
>    Affects Versions: 4.1.1.Final, 4.2.0.Alpha1
>            Reporter: Max Rydahl Andersen
>            Assignee: Ilya Buziuk
>            Priority: Critical
>             Fix For: 4.1.2.Final, 4.2.0.Alpha2
>
>
> both master and branch of vpe is using submodules
> https://github.com/jbosstools/jbosstools-vpe/blob/master/.gitmodules
> https://github.com/jbosstools/jbosstools-vpe/blob/jbosstools-4.1.x/.gitmodules
> Things wrong:
> A) These are pointing to personal repos
> B) No tags used
> C) readme.adoc not documenting it
> D) not announced anywhere
> E) git clone no longer sufficient
> We need to get this fixed/cleaned up in both branch and master.
>  *jbosstools-4.1.1.Final* - e498c091f79c140 ( JBIDE-15814 CordovaSim: Adding navigator.app.backHistory support )

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira