[jbosstools-issues] [JBoss JIRA] (JBIDE-16393) Fix/recover for bad usage of submodules in VPE

[Mickael Istria (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12937954#comment-12937954 ] 

Mickael Istria commented on JBIDE-16393:
----------------------------------------

>  why not just push the submodule's code into the appropriate plugin? Or to have submodules not in private repos?

Let it be clear, submodules are really a bad thing: people who get only the code can't build it correctly because submodules may not be resolved, they require much maintenance to update commits or they introduce uncertainty to find out what was actually used. All this increase complexity and introduces risk and confusion. So IMHO, it's just something we need to avoid as much as possible.
See the current example: you used submodules, and just by that, you were trapped by some of their biases (cf list of issues reported by Max).
We need to find something simpler and more universal.

If you're ok to put the code directly inside the plugin and maintain it there, go for it. It's actually the easiest solution from my POV.
                
> Fix/recover for bad usage of submodules in VPE
> ----------------------------------------------
>
>                 Key: JBIDE-16393
>                 URL: https://issues.jboss.org/browse/JBIDE-16393
>             Project: Tools (JBoss Tools)
>          Issue Type: Task
>          Components: browsersim, visual-page-editor-core
>    Affects Versions: 4.1.1.Final, 4.2.0.Alpha1
>            Reporter: Max Rydahl Andersen
>            Assignee: Ilya Buziuk
>            Priority: Critical
>             Fix For: 4.1.2.Final, 4.2.0.Alpha2
>
>
> both master and branch of vpe is using submodules
> https://github.com/jbosstools/jbosstools-vpe/blob/master/.gitmodules
> https://github.com/jbosstools/jbosstools-vpe/blob/jbosstools-4.1.x/.gitmodules
> Things wrong:
> A) These are pointing to personal repos
> B) No tags used
> C) readme.adoc not documenting it
> D) not announced anywhere
> E) git clone no longer sufficient
> We need to get this fixed/cleaned up in both branch and master.
>  *jbosstools-4.1.1.Final* - e498c091f79c140 ( JBIDE-15814 CordovaSim: Adding navigator.app.backHistory support )

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira