[jbosstools-issues] [JBoss JIRA] (JBIDE-17473) After forcestop, management shutdown does not clear forcestop flag

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-17473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977837#comment-12977837 ] 

Rob Stryker commented on JBIDE-17473:
-------------------------------------

That seems very strange.  During force stop, the management shutdownc ontroller doesn't know how to force the termination, so it finds out how you launched it, and gets a shutdown controller that matches it. In this case, that'd be RSEJBossCommandLineShutdownController, a subclass of RSECommandLineShutdownController. 

RSECommandLineShutdownController has a forceStop() method which clearly resets the flag to false. See the last line here:

{code}
	protected synchronized void forceStop() {
		if( getServer().getServerState() == IServer.STATE_STOPPED)
			return;
		String localPid = getProcessId();
		((ControllableServerBehavior)getControllableBehavior()).setServerStopped();
		if( localPid != null ) {
			try {
				ServerShellModel model = RSEHostShellModel.getInstance().getModel(getServer());
				String cmd = "kill -9 " + localPid;
				model.executeRemoteCommand("/", cmd, new String[]{}, new NullProgressMonitor(), 2000, true);
			} catch(CoreException ce ) {
				RSECorePlugin.pluginLog().logStatus(new Status(IStatus.ERROR, RSECorePlugin.PLUGIN_ID, "Unable to terminate remote process " + localPid, ce));
			}
		}
		clearProcessId();
		((ControllableServerBehavior)getControllableBehavior()).putSharedData(IDeployableServerBehaviorProperties.NEXT_STOP_REQUIRES_FORCE, false);
	}
{code}

> After forcestop, management shutdown does not clear forcestop flag
> ------------------------------------------------------------------
>
>                 Key: JBIDE-17473
>                 URL: https://issues.jboss.org/browse/JBIDE-17473
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 4.2.0.Beta2
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>             Fix For: 4.2.0.Beta3
>
>
> After a failed stop attempt, a flag is set on the server that the next stop attempt should be a force / kill of the process. 
> The second stop attempt is a force kill. 
> If you then start the server, and try to shut it down, it is force-killed immediately. This should not happen. It should try a normal stop first. 
> Solution is to clear the force flag after a force stop. 



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)