[jbosstools-issues] [JBoss JIRA] (JBIDE-17910) Assign and List directive fixes and tests

[Jiri Peterka (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-17910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jiri Peterka closed JBIDE-17910.
--------------------------------


Thanks Peter, looks good, verified with JBDS 8.0.0.CR1. Only issue is that after pasting code some change must be done first to update outline view but it's reported as new JIRA. 

> Assign and List directive fixes and tests
> -----------------------------------------
>
>                 Key: JBIDE-17910
>                 URL: https://issues.jboss.org/browse/JBIDE-17910
>             Project: Tools (JBoss Tools)
>          Issue Type: Task
>          Components: freemarker
>            Reporter: Peter Palaga
>            Assignee: Peter Palaga
>             Fix For: 4.2.0.CR1
>
>
> (1) {{AssignmentDirective.isNestable()}} looks only if the directive ends with {{"/>}} which is simply wrong for {{assign}}, {{local}} and {{global}} directives. [{{assign}} documentation|http://freemarker.org/docs/ref_directive_assign.html] lists several possible variants of the directive. {{AssignmentDirective.isNestable()}} should cover them all and tests need to be added.
> (2) It is clear from the usage of {{ItemSet.getFirstNestableItem(Stack<Item>)}} that it is supposed to return the last (as measured by time) item stored at the stack, not the first one. Therefore, {{getFirstNestableItem()}} needs to use a reverse order when iterating over the stack.
> These two issues should fix the improper tree presented in outline (when rendered with {{OutlineContentProvider.fullAstShown}}.



--
This message was sent by Atlassian JIRA
(v6.3.1#6329)