[jbosstools-issues] [JBoss JIRA] (JBIDE-17497) Servertools plugin heirarchy causes issues for clients

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-17497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040026#comment-13040026 ] 

Rob Stryker commented on JBIDE-17497:
-------------------------------------

This is for the most part fixed, but with some caveats.  The current state of the repo is that as.wtp.core currently depends on Project Archives to get its zip functionality. As far as I know, this is the only leftover that needs a solution, but I think it's strange to make a full new plugin just for one class. 

If you think I should close the issue for now and just accept that depending on as.wtp.core will force-install project archives, we can keep it as it currently is. I guess it just depends if ws / bpel / etc mind that depending on AS force-installs project archives, then it's fine. If they don't like it, then we may need to consider a change. 

Luckily, none of them have really complained about it as of late =P 

> Servertools plugin heirarchy causes issues for clients
> ------------------------------------------------------
>
>                 Key: JBIDE-17497
>                 URL: https://issues.jboss.org/browse/JBIDE-17497
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 4.2.0.Beta2
>            Reporter: Rob Stryker
>            Priority: Critical
>             Fix For: 4.3.0.Alpha2
>
>         Attachments: 2014-06-02 19.07.bmml, 2014-06-02 19.07.png
>
>
> The plugin heirarchy of ASTools is better than it used to be, but not good enough for what current consumers of ASTools need it for. 
> The problem is simple. There are 3 types of clients using ASTools API:
>   1) Those who need all of ASTools installed (including server adapter)
>   2) Those who only want access to interfaces, to use *if* server adapters is installed  (do NOT want as.core force installed)
>   3) Those who create their own server adapters, want to use interfaces and some impl classes, but do not want as.core (server adapters) installed. 
> Those of group 1 are no problem. 
> Those of group 2 want as.wtp.core and as.wtp.ui to be minimal implementations with very few (near-zero) dependencies
> Those of group 3 want as.wtp.core and as.wtp.ui to provide as much functionality as possible, including things like zipping archives, or integration with download runtimes. 
> An example of group 1 is jbosstools-central.
> An example of group 2 is ESB / BPEL
> An example of group 3 is FuseIDE
> Currently, there are classes in plugins positioned above as.core (ie, depend on as.core) that would be useful to FuseIDE (integration with stacks / runtimes / archives), but pushing these classes down into as.wtp.core / as.wtp.ui would mean the as.wtp.* plugins now require archives / stacks / yaml, and then so does bpel / esb. 
> There needs to be another set of core/ui plugins for extenders or implementers that do NOT bring in the server adapters. 
> Alternatively, we could move the server adapters out of as.core / as.ui and into two new higher-level plugins, as.serveradapter.core / as.serveradapter.ui, leaving as.core/as.ui as the new plugins to be extended by fuse-ide. 
> There are of course other possible solutions, but all possible solutions basically require new plugins with substantial class movement. 



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)