[jbosstools-issues] [JBoss JIRA] (JBIDE-21657) set up jobs to handle building from PRs

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165503#comment-13165503 ] 

Max Rydahl Andersen commented on JBIDE-21657:
---------------------------------------------

+1000 on this. I did templates for doing this but we never got the templatized jobs and at the time the builds were too intermingle to publish reliably to a separate site. If we can do it manually for the 40 odd or so jobs that is better than nothing.

About posting the build result - then I would say that is a big plus if we can, but there is more often than not more than 1 pr on our repos so I don't think having autoclean happen that way is practical. Can we do keep a week instead ? 

Also note that when some git pushes (with or without force) to the PR it should just overwrite the old pr content.

About the filtering - why not just run mvn install and just override the publish location ? the issue you have is because you are setting the various parameters on the job is it not ?

In the case of PR's you cannot feasibly know which branches etc. they are rebased against, and I would argue its better if we dont have to care. The PR builds should be built as you would do it locally, with only difference being where the publish destination goes.

> set up jobs to handle building from PRs
> ---------------------------------------
>
>                 Key: JBIDE-21657
>                 URL: https://issues.jboss.org/browse/JBIDE-21657
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 4.3.1.Beta2, 4.4.0.Alpha1
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>             Fix For: 4.3.1.CR1, 4.4.0.Alpha1
>
>
> First experimental build:
> https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-build-sites.aggregate.child-sites__pull-request_master/
> Output:
> http://download.jboss.org/jbosstools/neon/snapshots/builds/jbosstools-build-sites.aggregate.earlyaccess-site_master/2016-02-05_16-34-19-B1/all/repo/buildinfo.json
> {code}
>     "revision" : {
>         "HEAD" : "bfe76fb3f3c34d68b873d0acf715e2145e4cb805",
>         "currentBranch" : "HEAD",
>         "knownReferences" : [{
>             "name" : "origin",
>             "url" : "git://github.com/jbosstools/jbosstools-build-sites.git",
>             "ref" : "pr/221/merge"
>         }]
>     },
> {code}
> http://download.jboss.org/jbosstools/neon/snapshots/builds/jbosstools-build-sites.aggregate.earlyaccess-site_master/2016-02-05_16-34-19-B1/logs/GIT_REVISION.txt
> {code}
> #Fri Feb 05 16:42:42 EST 2016
> null\:merge=bfe76fb3f3c34d68b873d0acf715e2145e4cb805
> HEAD=bfe76fb3f3c34d68b873d0acf715e2145e4cb805
> {code}
> build log:
> {code}
> Started by upstream project "jbosstools-build-sites.aggregate.child-sites__pull-request_master" build number 1
> originally caused by:
>  GitHub pull request #221 of commit 50c10ad83d250d2b86f5697c4581ba8f9cb4937d, no merge conflicts.
> ...
> Fetching upstream changes from git://github.com/jbosstools/jbosstools-build-sites.git
>  > git -c core.askpass=true fetch --tags --progress git://github.com/jbosstools/jbosstools-build-sites.git +refs/heads/*:refs/remotes/origin/* +refs/pull/*:refs/remotes/origin/pr/*
> Checking out Revision bfe76fb3f3c34d68b873d0acf715e2145e4cb805 (refs/remotes/origin/pr/221/merge)
>  > git config core.sparsecheckout # timeout=10
>  > git checkout -f bfe76fb3f3c34d68b873d0acf715e2145e4cb805
> {code}
> vars:
> {code}
> -DghprbActualCommit=50c10ad83d250d2b86f5697c4581ba8f9cb4937d
> -DghprbPullId=221
> -Dsha1=origin/pr/221/merge
> "-DghprbPullDescription=GitHub pull request #221 of commit 50c10ad83d250d2b86f5697c4581ba8f9cb4937d, no merge conflicts." 
> -DghprbActualCommit=50c10ad83d250d2b86f5697c4581ba8f9cb4937d
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)