[jbosstools-issues] [JBoss JIRA] (JBIDE-23413) use Import-Package instead of Require-Bundle for slf4j.api [hibernate]

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-23413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13314297#comment-13314297 ] 

Nick Boldt edited comment on JBIDE-23413 at 10/31/16 1:11 PM:
--------------------------------------------------------------

When I run hibernate from an older devstudio installer install (devstudio-10.2.0.AM2-v20161014-1657-B6205-installer-standalone), I see the same missing icon on the properties sheet.

Also see this in the old devstudio's log:
{code}
Oct 31, 2016 1:07:31 PM org.hibernate.eclipse.HibernatePlugin start
INFO: HibernatePlugin Started
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
Oct 31, 2016 1:07:34 PM org.hibernate.tool.Version <clinit>
INFO: Hibernate Tools 5.2.0.CR1
{code}



was (Author: nickboldt):
When I run hibernate from an older devstudio installer install [1] I see the same missing icon on the properties sheet.

Also see this in the old devstudio's log:
{code}
Oct 31, 2016 1:07:31 PM org.hibernate.eclipse.HibernatePlugin start
INFO: HibernatePlugin Started
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
Oct 31, 2016 1:07:34 PM org.hibernate.tool.Version <clinit>
INFO: Hibernate Tools 5.2.0.CR1
{code}


> use Import-Package instead of Require-Bundle for slf4j.api [hibernate]
> ----------------------------------------------------------------------
>
>                 Key: JBIDE-23413
>                 URL: https://issues.jboss.org/browse/JBIDE-23413
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: hibernate, rpm
>    Affects Versions: 4.4.2.AM2
>            Reporter: Nick Boldt
>            Assignee: Koen Aers
>            Priority: Blocker
>             Fix For: 4.4.2.AM3
>
>         Attachments: hibernate-working-again-.png, org.hibernate.eclipse.unresolved.req.txt
>
>
> Because hibernate tools use Require-Bundle instead of Import-Package to depend on slf4j.api, this project cannot use the rhel implementation (rh-common-java rpm) version of slf4j.api 1.7.4 .jar when installed via rpm on rhel/fedora.
> Here's the line that is causing the problem:
> https://github.com/jbosstools/jbosstools-hibernate/blob/master/plugins/org.hibernate.eclipse/META-INF/MANIFEST.MF#L34
> We need to switch to using Import-Package to that *any* implementation of this package, regardless of *Bundle-SymbolicName*, can be used.
> More info in  JBDS-4136 
> See also:
> http://stackoverflow.com/questions/13959891/why-do-we-need-imported-packages-when-we-have-required-plug-ins-in-eclipse-p
> http://stackoverflow.com/questions/1865819/when-should-i-use-import-package-and-when-should-i-use-require-bundle



--
This message was sent by Atlassian JIRA
(v7.2.2#72004)