[keycloak-dev] Fwd: [keycloak] KEYCLOAK-2292 Broker login: remove identity provider prefix from auto… (#2141)

[Marek Posolda]

We agreed on this in some other thread: 
http://lists.jboss.org/pipermail/keycloak-dev/2016-January/006243.html

By default, firstBrokerLogin flow addresses conflicts in both email and 
username. So conflict in username can now be easily resolved and 
accounts can be linked at login time. So there is not much need to use 
tricky usernames like "brokerID.brokerUsername" anymore.

This PR addresses just default behaviour. If username mapper is used, it 
has always precedence. So there is still possibility to go back to 
previous behaviour or configure username template however you want.

Marek

On 29/01/16 19:49, Bill Burke wrote:
> Can I ask why we did this?  There will be name clashes.  User has the 
> power to change the name mapping already, don't they?
>
>
> -------- Forwarded Message --------
> Subject: 	[keycloak] KEYCLOAK-2292 Broker login: remove identity 
> provider prefix from auto… (#2141)
> Date: 	Fri, 29 Jan 2016 09:43:47 -0800
> From: 	Marek Posolda <notifications at github.com>
> Reply-To: 	keycloak/keycloak 
> <reply+000abeef51cc88b4da9732edfddbd34fa49c6a261b2d314092cf0000000112c366d392a169ce07bd2342 at reply.github.com> 
>
> To: 	keycloak/keycloak <keycloak at noreply.github.com>
>
>
>
> …generated username
>
> ------------------------------------------------------------------------
>
>
>         You can view, comment on, or merge this pull request online at:
>
> https://github.com/keycloak/keycloak/pull/2141
>
>
>         Commit Summary
>
>   * KEYCLOAK-2292 Broker login: remove identity provider prefix from
>     autogenerated username
>
>
>         File Changes
>
>   * *M*
>     services/src/main/java/org/keycloak/services/resources/IdentityBrokerService.java
>     <https://github.com/keycloak/keycloak/pull/2141/files#diff-0> (2)
>   * *M*
>     testsuite/integration/src/test/java/org/keycloak/testsuite/broker/AbstractIdentityProviderTest.java
>     <https://github.com/keycloak/keycloak/pull/2141/files#diff-1> (2)
>   * *M*
>     testsuite/integration/src/test/java/org/keycloak/testsuite/broker/AbstractKeycloakIdentityProviderTest.java
>     <https://github.com/keycloak/keycloak/pull/2141/files#diff-2> (4)
>   * *M*
>     testsuite/integration/src/test/java/org/keycloak/testsuite/broker/PostBrokerFlowTest.java
>     <https://github.com/keycloak/keycloak/pull/2141/files#diff-3> (10)
>
>
>         Patch Links:
>
>   * https://github.com/keycloak/keycloak/pull/2141.patch
>   * https://github.com/keycloak/keycloak/pull/2141.diff
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/keycloak/keycloak/pull/2141>.
>
>
> -- 
> Bill Burke
> JBoss, a division of Red Hat
> http://bill.burkecentral.com
>
>
>
>
> _______________________________________________
> keycloak-dev mailing list
> keycloak-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/keycloak-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/keycloak-dev/attachments/20160129/3c3f6581/attachment-0001.html