[keycloak-dev] KEYCLOAK-5032 - Pull Request

[carl-kristian.eriksen at telia.no]

Hi.

Thanks. Everything seems ok now.
The commit now includes forwarding of acr_values and prompt. The nonce work has been removed from the commit.

Could any of you give it a review and merge it?

Carl Kristian Eriksen

From: Marko Strukelj <mstrukel at redhat.com>
Date: Tuesday 3 October 2017 at 12:37
To: "Eriksen, Carl Kristian K. /External" <carl-kristian.eriksen at telia.no>
Cc: Bill Burke <bburke at redhat.com>, keycloak-dev <keycloak-dev at lists.jboss.org>
Subject: Re: [keycloak-dev] KEYCLOAK-5032 - Implementation question

CI uses extra options. Try running your tests with -Pauth-server-wildfly. That usually exposes extra issues.

On Mon, Oct 2, 2017 at 1:34 PM, <carl-kristian.eriksen at telia.no<mailto:carl-kristian.eriksen at telia.no>> wrote:
The second commit in the PR failed the CI build, but the tests does not fail locally.
Do you have any suggestions on how to handle this?

Carl Kristian Eriksen


On 29/09/17 16:41, "keycloak-dev-bounces at lists.jboss.org<mailto:keycloak-dev-bounces at lists.jboss.org> on behalf of carl-kristian.eriksen at telia.no<mailto:carl-kristian.eriksen at telia.no>" <keycloak-dev-bounces at lists.jboss.org<mailto:keycloak-dev-bounces at lists.jboss.org> on behalf of carl-kristian.eriksen at telia.no<mailto:carl-kristian.eriksen at telia.no>> wrote:

    Hi.

     I’ll follow up on the PR.

    Br / mvh
    Carl Kristian Eriksen
    On 29/09/17 15:50, "Bill Burke" <bburke at redhat.com<mailto:bburke at redhat.com>> wrote:

        Do you want to continue talking on the PR or here?  I had some
        concerns with your PR.

        On Wed, Sep 27, 2017 at 5:45 AM,  <carl-kristian.eriksen at telia.no<mailto:carl-kristian.eriksen at telia.no>> wrote:
        > https://issues.jboss.org/browse/KEYCLOAK-5032 describes two requested query parameters: acr_values and nonce
        >
        > Our requirements are for acr_values and prompt, and I’m working on a pull request for these two.
        >
        > How many pull requests do you want?
        > Should I make sure that (each)PR includes support for one, two or three query parameters
        >
        > Can the “prompt” parameter be added to KEYCLOAK-5032, or do I need another Jira task for the “prompt” parameter?
        >
        > Br / mvh
        > Carl Kristian Eriksen
    > _______________________________________________
        > keycloak-dev mailing list
        > keycloak-dev at lists.jboss.org<mailto:keycloak-dev at lists.jboss.org>
        > https://lists.jboss.org/mailman/listinfo/keycloak-dev



        --
        Bill Burke
        Red Hat



    _______________________________________________
    keycloak-dev mailing list
    keycloak-dev at lists.jboss.org<mailto:keycloak-dev at lists.jboss.org>
    https://lists.jboss.org/mailman/listinfo/keycloak-dev


_______________________________________________
keycloak-dev mailing list
keycloak-dev at lists.jboss.org<mailto:keycloak-dev at lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/keycloak-dev