[keycloak-dev] Make AuthenticationSessionModel available through KeycloakContext in KeycloakSession?

[Chris Smith]

+1 from me.  I could of used this awhile ago.

-----Original Message-----
From: keycloak-dev-bounces at lists.jboss.org <keycloak-dev-bounces at lists.jboss.org> On Behalf Of Marek Posolda
Sent: Tuesday, July 2, 2019 11:21 AM
To: Vlastimil Elias <velias at redhat.com>; keycloak-dev <keycloak-dev at lists.jboss.org>
Subject: Re: [keycloak-dev] Make AuthenticationSessionModel available through KeycloakContext in KeycloakSession?

Just adding +1 from me as we discussed personally and in the JIRA.

Marek

On 02/07/2019 17:04, Vlastimil Elias wrote:
> Hi,
>
> as I described in [1] , we have a problem that 
> AuthenticationSessionModel is not available in EventListenerProvider 
> SPI and we need it there (we have to use dirty hacks now to workaround 
> this problem, and we are not able to workaround it in all cases still).
>
> I discussed this with Marek Posolda, and a viable solution seems to be 
> to make current AuthenticationSessionModel available through 
> KeycloakContext in KeycloakSession in a same way as current RealmModel 
> and few other objects. This way it will be automatically available in 
> all SPI's without need to update each of them (it may be null if SPI 
> is called out of AuthenticationSession context naturally, so SPI 
> implementer have to check it correctly).
>
> Dos anybody have any obligation against this proposal, or better proposal?
>
> If not, the I can try to prepare and provide PR against Keycloak master.
> It is really important for us to make this problem resolved, but I 
> can't afford to waste my time by PR which will not be accepted at the end.
>
> Thanks for any reaction
>
> Vlastimil
>
>
> [1] https://issues.jboss.org/browse/KEYCLOAK-10209
>
>

_______________________________________________
keycloak-dev mailing list
keycloak-dev at lists.jboss.org
https://lists.jboss.org/mailman/listinfo/keycloak-dev