[keycloak-dev] KEYCLOAK-6795 / Silent token refresh for implicit flow

[Niko Köbler]

Thanks Michal,

thanks for the help.
I struggled before with the notation from here https://github.com/keycloak/keycloak/blob/master/testsuite/integration-arquillian/HOW-TO-RUN.md#run-adapter-tests, as I needed to put the class name of the tests in quotes: -Dtest="org.keycloak.testsuite.adapter.**.*Test" - otherwise I got some shell errors.

I just pushed the test, build is running.
(It's like a nightmare to implement some tests, if you are not aware of all this stuff, as all your test classes are poorly (aka not-at-all) documented. If you want contributions from the community, you should change this!)
Hope to get it merged soon. :)

Regards,
- Niko

> Am 11.03.2019 um 09:45 schrieb Michal Hajas <mhajas at redhat.com>:
> 
> Hello,
> 
> thank you very much for the contribution. 
> 
> You can run JavascriptAdapterTest class using the following command executed from keycloak directory:
> 
> mvn clean install -f testsuite/integration-arquillian/pom.xml -Dtest=JavascriptAdapterTest
> 
> Best regards,
> Michal
> 
> On Sat, Mar 9, 2019 at 10:41 AM Niko Köbler <niko at n-k.de <mailto:niko at n-k.de>> wrote:
> I've just created a pull request for this issue, including docs, but still without tests.
> https://github.com/keycloak/keycloak/pull/5932 <https://github.com/keycloak/keycloak/pull/5932>
> 
> As the tests are quite complex to run, and I didn't find any information about how to run/execute just the JavascriptAdapterTest.java class without running the whole testsuite over and over again, I'd appreciate any help/hint, of how to run this test only.
> 
> Thanks,
> - Niko
> 
> 
> 
> > Am 08.03.2019 um 13:19 schrieb Niko Köbler <niko at n-k.de <mailto:niko at n-k.de>>:
> > 
> > Hi team,
> > 
> > I'd like to volunteer for https://issues.jboss.org/browse/KEYCLOAK-6795 <https://issues.jboss.org/browse/KEYCLOAK-6795> as this is needed in one of my customers projects and it increases security in handling tokens in SPAs.
> > I've already an idea of how to implement it (and a very rough working draft), but would like to discuss this first with someone of you.
> > Anybody interested in discussing?
> > 
> > - Niko
> > 
> > 
> > _______________________________________________
> > keycloak-dev mailing list
> > keycloak-dev at lists.jboss.org <mailto:keycloak-dev at lists.jboss.org>
> > https://lists.jboss.org/mailman/listinfo/keycloak-dev <https://lists.jboss.org/mailman/listinfo/keycloak-dev>
> 
> 
> _______________________________________________
> keycloak-dev mailing list
> keycloak-dev at lists.jboss.org <mailto:keycloak-dev at lists.jboss.org>
> https://lists.jboss.org/mailman/listinfo/keycloak-dev <https://lists.jboss.org/mailman/listinfo/keycloak-dev>