[keycloak-dev] Running Node.js tests with Chrome instead of Phantomjs

[Michal Hajas]

I agree. I sent PR to Node.js adapter already and I created a SPIKE [1] for
investigation which browser would be the best for replacing Phantomjs for
Java Arquillian testsuite. Feel free to comment or update.

Michal

[1] https://issues.jboss.org/browse/KEYCLOAK-10392

On Thu, May 23, 2019 at 9:48 AM Stian Thorgersen <sthorger at redhat.com>
wrote:

> +1 as long as chrome-headless works everywhere I'd rather see that as the
> default and stop using phantom-js and htmlunit (or whatever it's called).
> From looking at this a looooong time ago I seem to remember chrome-headless
> was faster than everything else.
>
> On Thu, 23 May 2019 at 08:51, Michal Hajas <mhajas at redhat.com> wrote:
>
>> I created an issue [1] and I will start to work on making it work on
>> Travis.
>>
>> [1] https://issues.jboss.org/browse/KEYCLOAK-10359
>>
>> On Wed, May 22, 2019 at 7:46 PM Bruno Oliveira <bruno at abstractj.org>
>> wrote:
>>
>> > Hi Michal, I'm not against changing the browser used for testing, as
>> > long as we keep Travis happy, like Vašek mentioned.
>> >
>> > Before we make this decision, I suggest to first isolate the tests and
>> > give it a try with some headless browser (maybe chrome-headless). After
>> > that, we can decide whether or not we should drop phantomjs.
>> >
>> > On 2019-05-22, Michal Hajas wrote:
>> > > Hi all,
>> > >
>> > > currently, we are using phantomjs browser for running Node.js tests
>> [1].
>> > > However, we are experiencing some issues which seem to be caused by
>> > > phantomjs, so we are considering to change the default browser from
>> > > phantomjs to headless chrome.
>> > >
>> > > Do you have some objections why not to do so?
>> > >
>> > > [1]
>> > >
>> >
>> https://github.com/keycloak/keycloak-nodejs-connect/blob/master/test/utils/webdriver.js#L25
>> > > _______________________________________________
>> > > keycloak-dev mailing list
>> > > keycloak-dev at lists.jboss.org
>> > > https://lists.jboss.org/mailman/listinfo/keycloak-dev
>> >
>> > --
>> >
>> > abstractj
>> >
>> _______________________________________________
>> keycloak-dev mailing list
>> keycloak-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/keycloak-dev
>
>