[keycloak-dev] Remove built-in themes from themes directory

[Stian Thorgersen]

Is it really that much of an inconvenience to unzip a file?

# cd themes
# unzip ../themes.zip .



On Thu, 19 Sep 2019, 14:23 Stan Silvert, <ssilvert at redhat.com> wrote:

> -1
>
> I think this would be bad from a developer's usability perspective.  We
> should not make it harder for the developer to see what he is extending.
>
> Also, a developer who is new to Keycloak can make small changes to the
> built-in theme and see the effects right away.  This is important for
> the "out-of-the-box" experience where a developer is trying to decide
> whether or not to use Keycloak.
>
> We shouldn't make it harder to start hacking on themes.  We just warn
> them that the proper way to do it in production is to extend the theme.
>
> It's just like what we did with WildFly and the "toy" database that
> comes with it.  We want developers to be able to get started a quickly
> as possible, while noting that this is not suitable for production.
>
> On 9/19/2019 3:39 AM, Stian Thorgersen wrote:
> > See thread "Shared messages between themes". I propose to remove built-in
> > themes from themes directory and rather load from a module/jar.
> >
> > Reasoning behind this is two fold:
> >
> > a) Support theme resources for sharing messages between themes
> > b) Built-in themes should not be modified
> >
> > Within themes we'd update the README.txt file to provide the location of
> > the built-in themes so users can crack open the jar (zip) to view the
> > built-in themes for reference when they are creating their own custom
> > themes.
> > _______________________________________________
> > keycloak-dev mailing list
> > keycloak-dev at lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/keycloak-dev
>
>
> _______________________________________________
> keycloak-dev mailing list
> keycloak-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/keycloak-dev