[rules-dev] BUG: [5.3.0.Final] CollectSetAccumulateFunction should probably use IdentityHashMap internally

[SirMungus]

Edson Tirelli-4 wrote
> 
> I see what you are saying and I think it works. Although, it will be
> heavier, it would cover scenarios not covered by the current
> implementation.
> 
>    My suggestion is if you can, please create a test case for the problem,
> change the collectSet accumulate function to do what you propose and send
> a
> pull request. I will review it and apply. I think in this case, making
> user's life easier by not requiring immutability might trump performance,
> but we need to evaluate some tests just in case.
> 
Edson, thanks for the offer.  I'll see what I can do.  Since I work at a
financial services company, I practically have to get Obama's permission to
do anything official on an open source project. :)

--
View this message in context: http://drools.46999.n3.nabble.com/BUG-5-3-0-Final-CollectSetAccumulateFunction-should-probably-use-IdentityHashMap-internally-tp3774079p3784963.html
Sent from the Drools: Developer (committer) mailing list mailing list archive at Nabble.com.