[rules-users] maven-drools-plugin, anyone?

[Geoffrey De Smet]

Angar,

I 've been looking at the code: great stuff, nice quality, nice work!
We definitely want to pull the directory maven-drools-plugin of your git 
repository into the git repository droolsjbpm-tools,
if you let us.

A couple of notes:
- Are the other modules (api-tests, cities-fact-model, ...) required? 
Can they be refactored into the integration tests of the 
maven-drools-plugin module?
- We'll probably have to rename it from maven-drools-plugin to 
drools-maven-plugin:
-- Only the build-in plugins of org.apache.maven seem to follow the 
pattern maven-x-plugin.
-- All mojo plugins follow x-maven-plugin: 
https://fisheye.codehaus.org/browse/mojo/tags
-- Examples in the sonatype book: 
http://www.sonatype.com/books/mvnref-book/reference/writing-plugins-sect-custom-plugin.html
- Packaging dkp
-- "dkp" is too short and can easil conflict with "debian kernel 
packaging" or something :)
-- Do we need a new packaging type? Isn't this about generating just 
another set of resources in the jar? What if we want to do this in a war 
(so packaging must be "war")?
-- I believe we shouldn't define a packaging type and instead, force to 
user to declare the goal "compile" (which is attached after the compile 
phase by default (or maybe another phase by default?))
- I don't like the "passes" thing. It violates "Keep it simple and 
stupid" and makes creating the plugin difficult.
-- If I understand it correctly, it is a workaround on the declare 
keyword forward referencing problem. Is there a jira for that problem in 
JBRULES?
- Use filesets, see 
http://www.sonatype.com/people/2011/03/configuring-plugin-goals-in-maven-3/


Anyway, let's talk :) I am #ge0ffrey on irc.codehaus.org

Op 10-03-11 10:03, Geoffrey De Smet schreef:
>
> Op 10-03-11 09:27, Ansgar Konermann schreef:
>> Hi Geoffrey,
>>
>> On 10.03.2011 08:58, Geoffrey De Smet wrote:
>>> There's a jira for a maven-drools-plugin with possible requirements
>>>      and I believe there already 2 implementations in the wild.
>>>
>>> IMHO:
>>> 1) It should be centralized into the droolsjbpm-tools repository.
>>> Make a pull request on that repository and I 'll peer review it.
>>>
>> It's ASL licensed - if you feel like it, fork it, pull it, do whatever
>> you like under this license. My team and I needed a starting point and
>> we found it too complicated to work with the drools source code
>> repository during the last few months/weeks.
> Understandable.
> The big changes are done, so
> the drools source code repository should be stable any day now :)
> Watch the lights on hudson:
>     https://hudson.jboss.org/hudson/view/Drools%20jBPM/
>>> 2) The goals etc should follow maven naming conventions.
>>> 3) There should be integration tests.
>>> 4) It should use the latest maven 3 best practices.
>>>
>>> In short: it's best to start from a really good, existing, up-to-date,
>>> ASL-licensed other maven plugin that does non-java compiling.
>>>
>> Is this just a write-down of your thoughts with no relation to the
>> implementation described on the given web page, or should it actually
>> referr to the given implementation?
> Just a quick write down of my thoughts,
> I haven't had the change to check your implementation yet.
> Sorry for the confusion.
>
> Afaik, from maven 2 to maven 3, a lot of the plugin infrastructure has
> been deprecated and replaced
> by new API's (aether, it testing, ...), so I was wondering if the plugin
> takes advantage of those things (if appropriate).
>
>> If it should be the latter, could you be a bit more concrete (except for
>> maybe point 1)? Admitted, I'm new to maven plugin development, but I
>> tried hard and thus can't see where points 2 to 4 are violated. If there
>> are any points to be improved, I'd be glad to fix them, given some
>> pointers to relevant information and a ticket in the bug tracker (also
>> linked from the web page).
>>
>> Best regards
>>
>> Ansgar
>>> Op 09-03-11 22:42, Mauricio Salatino schreef:
>>>
>>>> I will take a look on that right now..
>>>> I was planning to do the same for some of my example projects.
>>>> I will come back with some feedback!
>>>> Greetings.
>>>>
>>>> On Wed, Mar 9, 2011 at 6:29 PM, Ansgar Konermann
>>>> <ansgar.konermann at googlemail.com
>>>> <mailto:ansgar.konermann at googlemail.com>>    wrote:
>>>>
>>>>        Hi,
>>>>
>>>>        I prepared a tiny drools compiler plugin for Maven 3. It currently
>>>>        contains the smallest feature-set which is potentially useful for my
>>>>        colleagues at work, so up to now it's no more than a starting
>>>>        point for
>>>>        my team. Nevertheless, I invite you to take a look at it, comment
>>>>        on it
>>>>        and suggest features _you_ would like to see in the plugin in one
>>>>        of its
>>>>        future releases.
>>>>
>>>>        There's some inital documentation here:
>>>>        http://passion.forco.de/content/maven-drools-plugin
>>>>
>>>>        Looking forward to your comments.
>>>>
>>>>        Best regards
>>>>
>>>>        Ansgar
>>>>        _______________________________________________
>>>>        rules-users mailing list
>>>>        rules-users at lists.jboss.org<mailto:rules-users at lists.jboss.org>
>>>>        https://lists.jboss.org/mailman/listinfo/rules-users
>>>>
>>>>
>>>>
>>>>
>>>> -- 
>>>>     - CTO @ http://www.plugtree.com
>>>>     - MyJourney @ http://salaboy.wordpress.com
>>>>     - Co-Founder @ http://www.jbug.com.ar
>>>>
>>>>     - Salatino "Salaboy" Mauricio -
>>>>
>>>>
>>>> _______________________________________________
>>>> rules-users mailing list
>>>> rules-users at lists.jboss.org
>>>> https://lists.jboss.org/mailman/listinfo/rules-users
>>>>
>> _______________________________________________
>> rules-users mailing list
>> rules-users at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/rules-users
>>

-- 
With kind regards,
Geoffrey De Smet