[seam-dev] Code Review on Seam Modules

[George Gastaldi]

Yeah, I forgot I also need to create submodules on impl so that each
implementation is isolated from each other before merging.

Lets see what comes next :)

Em 26/05/2011, às 02:09, Dan Allen <dan.j.allen at gmail.com> escreveu:

Don't forget that Jordan has a Pentaho implementation in prototype to look
through as well. Be gentle, it's still on a branch :)

https://github.com/jganoff/reports/tree/SEAMREPORTS-5

-Dan

On Thu, May 26, 2011 at 01:05, Dan Allen <dan.j.allen at gmail.com> wrote:

> Thanks for raising this George.
>
> Both of these modules are really on fire right now (come to think of it,
> that's true of a lot of modules). But anyway, definitely look through them.
> That's what really matters early on. And it's really easy to browse the code
> on github [1] [2]. Hint, focus on the APIs. (Type 't' to see all files and
> navigate them)
>
> Unfortunately, at this point you can only comment on commits, so simply
> post to the mailinglist or chat in IRC if you want to provide general
> feedback.
>
> On Thu, May 26, 2011 at 00:47, George Gastaldi <gegastaldi at gmail.com>wrote:
>
>> I encourage to extend that good practice whenever is possible to other
>> modules as well.
>> Could be a topic to discuss on the meeting next week.
>>
>
> George and Antoine got me thinking that perhaps we should have a "request
> for review" section on the project site (or some other feed mechanism) so
> that you can see what's currently "up for review". This should help
> passer-byes know when and where to jump in.
>
> I recommend using this template for requesting a review:
>
> Module: (e.g., Social)
> Type: (e.g., code | documentation | example)
> Focus: (e.g., APIs, type names, implementation strategy, etc)
> Other notes:
>
> The clearer the focus, the more feedback you are likely going to get (since
> people know what to look for).
>
> -Dan
>
> [1] https://github.com/seam/social
> [2] https://github.com/seam/reports
>
> --
> Dan Allen
> Principal Software Engineer, Red Hat | Author of Seam in Action
> Registered Linux User #231597
>
> http://www.google.com/profiles/dan.j.allen#about
> http://mojavelinux.com
> http://mojavelinux.com/seaminaction
>



-- 
Dan Allen
Principal Software Engineer, Red Hat | Author of Seam in Action
Registered Linux User #231597

http://www.google.com/profiles/dan.j.allen#about
http://mojavelinux.com
http://mojavelinux.com/seaminaction
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/seam-dev/attachments/20110526/005e21f8/attachment.html