[wildfly-dev] Subsystems to advertise implicit and optional dependencies to galleon

[James Perkins]

On Mon, Nov 12, 2018 at 3:54 AM Jean-Francois Denise <jdenise at redhat.com>
wrote:

> Thank-you.
>
> On 09/11/2018 19:45, James Perkins wrote:
>
> The main reason those modules are dependencies of the logging subsystem is
> because they are not really required for the subsystem itself with the
> exception of org.jboss.logging. Those module dependencies are added to
> deployments for convenience. So really they're not required at all unless
> the user is using one of those logging frameworks and they want the logging
> subsystem to control the logging output.
>
> There is some logic to attempt to load the module, if it succeeds, then
> the dependency is added as a required one. Could this be replaced by an
> optional dependency and no module loading? These modules would have to to
> be added thanks to addAdditionalOptionalPackages.
>

I guess it really does make sense to have them as optional dependencies in
the module.xml. Using the addAddtionalOptionalPackages would work too
though. I'd be good with doing it either way so which ever makes the most
sense for Galleon.

>
> This may be somewhat of an edge case because if the user doesn't use, say
> slf4j, then there is no real reason to include the dependency unless of
> course another module uses it. I do wonder if we should remove the
> org.jboss.logging.jul-to-slf4j-stub module and just put the library as a
> resource root to org.slf4j, but that's slightly OT :)
>
>
> --
> James R. Perkins
> JBoss by Red Hat
>
>
> _______________________________________________
> wildfly-dev mailing listwildfly-dev at lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/wildfly-dev
>
>
> _______________________________________________
> wildfly-dev mailing list
> wildfly-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/wildfly-dev



-- 
James R. Perkins
JBoss by Red Hat
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/wildfly-dev/attachments/20181112/a8044d03/attachment.html