[windup-dev] Windup legacy rules rewriting

[Lincoln Baxter, III]

Hey Bruno,

Yeah, we definitely plan on externalizing this, but I'd rather not just
create a separate data format just to keep this stuff out of java (I'd
rather implement it properly via the Groovy simplified rule stuff, which
this is a prerequisite for.

My only point here is that I see little difference between putting strings
in a .CSV file and in a Java file considering we'll be exposing this in
groovy anyway :)

~Lincoln


On Tue, Jul 15, 2014 at 5:35 PM, Bruno Georges <bgeorges at redhat.com> wrote:

> Thinking out loud, having the ability to externalise rules is a big plus
> imo, I recall my years writing simplybusiness.co.uk 's Quotation engine,
> having rules in Java was not ideal at all.
> Hence, I am still a proponent of this approach. It has many advantages,
> productivity/testability are 2 of them.
>
> my 2 cents.
>
> Bruno
>
> On 16/07/2014, at 6:10 am, Lincoln Baxter, III <lincolnbaxter at gmail.com>
> wrote:
>
> I do remember this discussion, and I think that while it's one possible
> solution, it's not really beneficial to have the separated out into
> non-java files. In this particular scenario, I do think that writing
> multiple rules is probably not what we want, but we do probably want to
> keep the data in Java, in the ConfigurationProvider or a closely related
> class.
>
> Matej was just doing what he thought we asked him to do, literally port
> the rules 1:1. He now understands we meant "port the functionality." :)
>
>
> On Tue, Jul 15, 2014 at 12:31 PM, Ondrej Zizka <ozizka at redhat.com> wrote:
>
>> Hi,
>>
>> just a note on $SUBJ. I may be wrong, but I recall we agreed that the
>> old rules, since being so monotonous, could have one rule, which would
>> load the simple data from a static file(s), and one rule which would
>> execute them. E.g. a simple .csv file with regex, hint, reference. Or
>> JSON/XML if needed.
>>
>> Now Matej creates one java rule per each legacy regex.
>> Is there some change in the previous plan?
>> Both solutions have obvious advantages, I just want to know what was the
>> decision.
>>
>> Thanks,
>> Ondra
>> _______________________________________________
>> windup-dev mailing list
>> windup-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/windup-dev
>>
>
>
>
> --
> Lincoln Baxter, III
> http://ocpsoft.org
> "Simpler is better."
> _______________________________________________
> windup-dev mailing list
> windup-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/windup-dev
>
>
>
> _______________________________________________
> windup-dev mailing list
> windup-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/windup-dev
>



-- 
Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20140716/52a12b45/attachment.html