[windup-dev] Iteration*Managers

[Ondrej Zizka]

Let's move this discussion to
https://issues.jboss.org/browse/WINDUP-97?jql=project%20%3D%20WINDUP

Ondra


On 26.6.2014 04:20, Ondrej Zizka wrote:
> It seems that the interface could be reduced from
>
> public interface IterationSelectionManager {
>     Iterable<WindupVertexFrame> getFrames(GraphRewrite event, VarStack 
> varStack);
> }
>
> to just
>
> public interface FramesSelector {
>     Iterable<WindupVertexFrame> getFrames();
> }
>
> Because:
>
> 1) Has not much to do with iteration
> 2) the stack and the event do not necessarily have to be needed / 
> available at the time of calling getFrames(),
> 3) event is used just to get the context, which may be set in impl's 
> constructor (or injected?),
> 4) The variables stack should be accessible from the context, i.e. 
> somehow from the event. and if not, 3) applies here too.
>
> WDYT?
>
> Ondra
>
>
>
> On 26.6.2014 03:39, Ondrej Zizka wrote:
>> On 25.6.2014 08:04, Lincoln Baxter, III wrote:
>>> IterationSelectionManager provides access to the specified selection 
>>> variable (e.g. something that was selected via 
>>> GraphSearchConditionBuilder (this name was initially "Selection" and 
>>> we probably need to think about changing the name to something else)
>> It's rather some kind of view/projection than a manager - the 
>> SelectionFactory / VarStack actually manages both.
>> And I ponder how many ways to get the frames based on a name can 
>> there be. Can one var name lead to different set frames? If not, then 
>> that's my point - if there's just one, then this layer is not 
>> necessary. Or do I miss something?
>
>
>
> _______________________________________________
> windup-dev mailing list
> windup-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/windup-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20140626/a9a03bb4/attachment-0001.html