[windup-dev] WRT RulePhase changes

[Lincoln Baxter, III]

That said, you are right that as far as end users are concerned, having
"perfect" code is not a requirement as long as it works, but I refuse to
play the "deferred maintainance" / "code debt" game.

On Wed, Jan 28, 2015 at 1:00 PM, Lincoln Baxter, III <
lincolnbaxter at gmail.com> wrote:

> On Tue, Jan 27, 2015 at 10:48 PM, Ondrej Zizka <ozizka at redhat.com> wrote:
>
>>  If I may state my humble opinion:
>>
>> 1) java-based ruleset authors do not care about how ugly our internal
>> code is :)
>>
>
> I beg to differ, and I feel strongly that as a high-end software company,
> we need to present a *very* professional image. Even if it's "just internal
> code."
>
>
>> 2) RulePhase.<Ctrl+space> is much much quicker than looking up the
>> information.
>>     The thing is, that our users do not even know that there's some
>> superclass they can look for, they will just copy the quickstarts, and
>> seeing
>>
>
> <CTRL>-T
>
>
>> RulePhase.Initial.class suggests very clearly that there are more to pick
>> from in RulePhase. Whereas "InitialPhase.class" doesn't.
>>
>> 3) Keeping them in one file will make it easier for us to maintain
>>
>
> Again I beg to differ.
>
>
>>
>>
>> On 27.1.2015 04:39, Lincoln Baxter, III wrote:
>>
>> Hey, good question, but no. You can always look in that package and see
>> all of the phases we have. Or use the IDE to quick-search for types
>> implementing RulePhase, etc. Not worth making ugly code for that when the
>> IDE or GitHub will tell you exactly the same information.
>>
>> On Mon, Jan 26, 2015 at 10:04 AM, Ondrej Zizka <ozizka at redhat.com> wrote:
>>
>>>  Hi,
>>>
>>> I am updating the quickstarts to match the recent changes
>>> WINDUP-277 <https://issues.jboss.org/browse/WINDUP-277> Replace
>>> Migration "Phases" with dependencies
>>> <https://issues.jboss.org/browse/WINDUP-277> .
>>>
>>> The subclasses are small and just a few.
>>> Could we move them as inner classes of RulePhase?
>>> This would be beneficial:
>>> 1) One could write "RulePhase." to get a list of built-in phases instead
>>> of going to the documentation.
>>> 2) We would get rid of several small .java files
>>>
>>> Ondra
>>>
>>> _______________________________________________
>>> windup-dev mailing list
>>> windup-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/windup-dev
>>>
>>
>>
>>
>>  --
>> Lincoln Baxter, III
>> http://ocpsoft.org
>> "Simpler is better."
>>
>>
>> _______________________________________________
>> windup-dev mailing listwindup-dev at lists.jboss.orghttps://lists.jboss.org/mailman/listinfo/windup-dev
>>
>>
>>
>> _______________________________________________
>> windup-dev mailing list
>> windup-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/windup-dev
>>
>
>
>
> --
> Lincoln Baxter, III
> http://ocpsoft.org
> "Simpler is better."
>



-- 
Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/windup-dev/attachments/20150128/d15ed056/attachment.html