[rules-dev] Issues with fixing duplicate rule name declarations in separate resource files.

Mark Proctor mproctor at codehaus.org
Sat Jul 9 19:23:52 EDT 2011


On 10/07/2011 00:20, Mark Proctor wrote:
> On 09/07/2011 23:59, Mikael Lönneberg wrote:
>> Hi,
>>
>> In trying to fix JBRULES-2730 and JBRULES-3063, I noticed that fixing 
>> this issue will actually break MiscTest#testRuleReplacement.
>> So should this test case be rewritten to not allow rule replacement, 
>> or are there circumstances where rule replacements are allowed and if 
>> that is the case what are those circumstances?
> Rule replacement is allowed and an important part of a dynamic rule 
> engine. I believe what we do is disallow it from the same resource 
> (should double check that) i.e. a drl that repeats the rule twice is 
> an error. If you load a later resource it will overwrite the previous.
Thinking about this some more. We should probably add a "getWarnings" as 
well as getErrors. Rule overwriting would come with a warning.

We might even find a way build warning filters, a composite set of 
warnings to fail on, but user defineable.
>>
>> ConsequenceOffsetTest.testConsequenceOffset also fails due to loading 
>> two resource files with the same package and rule name defined in the 
>> different files.
>>
> Sounds like a bug, can you update some stronger tests and fix?
>
> Mark
>>
>> Kind regards
>>
>> Mikael Lonneberg - gwendo
>>
>>
>> _______________________________________________
>> rules-dev mailing list
>> rules-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/rules-dev
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/rules-dev/attachments/20110710/c409bfa0/attachment.html 


More information about the rules-dev mailing list