1:59 p.m.
RemoteGatewayListener ignores local FTP location
------------------------------------------------
Key: JBESB-2524
URL: https://jira.jboss.org/jira/browse/JBESB-2524
Project: JBoss ESB
Issue Type: Patch
Security Level: Public (Everyone can see)
Affects Versions: 4.4
Reporter: George Gastaldi
Priority: Trivial
The class RemoteGatewayListener does an ugly checking for the temporary directory and
ignores any attempt to define a local directory:
This is the actual code :
..
protected void checkMyParms() throws ConfigurationException, RegistryException,
GatewayException
{
try
{
File temp = File.createTempFile("FTPdown", ".tmp");
temp.delete();
String localDir = temp.getParent();
if (null==localDir)
localDir=new File("").getAbsolutePath();
config.setAttribute(RemoteFileSystem.PARMS_LOCAL_DIR, localDir);
final String remoteDir = config.getAttribute(ListenerTagNames.FILE_INPUT_DIR_TAG) ;
config.setAttribute(RemoteFileSystem.PARMS_REMOTE_DIR, remoteDir);
EPR epr = ListenerUtil.assembleEpr(config);
if (epr instanceof FTPEpr) {
FTPEpr ftpEpr = (FTPEpr) epr;
RemoteFileSystem rfs = RemoteFileSystemFactory.getRemoteFileSystem(ftpEpr, true);
rfs.quit();
} else {
throw new GatewayException("This Gateway only accepts FTP and SFTP.");
}
}
catch (IOException ex)
{
throw new ConfigurationException(ex);
}
catch (RemoteFileSystemException ex)
{
throw new ConfigurationException(ex);
}
}
...
The Listener should check first if a path has been defined before attempting to discover
the local directory.
BTW, the first lines could be replaced by System.getProperty("java.io.tmpdir"),
instead of creating and deleting a file (expensive unnecessary operation).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:26 a.m.
New subject: [JBoss JIRA] Updated: (JBESB-2524) RemoteGatewayListener ignores local FTP location
[
https://jira.jboss.org/jira/browse/JBESB-2524?page=com.atlassian.jira.plu...
]
Kevin Conner updated JBESB-2524:
--------------------------------
Component/s: Transports
Fix Version/s: 4.6
Moving to 4.6, the code should definitely be using the system property rather than
creating temporary files.
RemoteGatewayListener ignores local FTP location
------------------------------------------------
Key: JBESB-2524
URL: https://jira.jboss.org/jira/browse/JBESB-2524
Project: JBoss ESB
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.4
Reporter: George Gastaldi
Priority: Trivial
Fix For: 4.6
The class RemoteGatewayListener does an ugly checking for the temporary directory and
ignores any attempt to define a local directory:
This is the actual code :
..
protected void checkMyParms() throws ConfigurationException, RegistryException,
GatewayException
{
try
{
File temp = File.createTempFile("FTPdown", ".tmp");
temp.delete();
String localDir = temp.getParent();
if (null==localDir)
localDir=new File("").getAbsolutePath();
config.setAttribute(RemoteFileSystem.PARMS_LOCAL_DIR, localDir);
final String remoteDir = config.getAttribute(ListenerTagNames.FILE_INPUT_DIR_TAG) ;
config.setAttribute(RemoteFileSystem.PARMS_REMOTE_DIR, remoteDir);
EPR epr = ListenerUtil.assembleEpr(config);
if (epr instanceof FTPEpr) {
FTPEpr ftpEpr = (FTPEpr) epr;
RemoteFileSystem rfs = RemoteFileSystemFactory.getRemoteFileSystem(ftpEpr, true);
rfs.quit();
} else {
throw new GatewayException("This Gateway only accepts FTP and SFTP.");
}
}
catch (IOException ex)
{
throw new ConfigurationException(ex);
}
catch (RemoteFileSystemException ex)
{
throw new ConfigurationException(ex);
}
}
...
The Listener should check first if a path has been defined before attempting to discover
the local directory.
BTW, the first lines could be replaced by System.getProperty("java.io.tmpdir"),
instead of creating and deleting a file (expensive unnecessary operation).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:52 a.m.
New subject: [JBoss JIRA] Commented: (JBESB-2524) RemoteGatewayListener ignores local FTP location
[
https://jira.jboss.org/jira/browse/JBESB-2524?page=com.atlassian.jira.plu...
]
Tom Fennelly commented on JBESB-2524:
-------------------------------------
What was the intention of the ftpLocalDir setting? From what I can see in the code...
there's no config option (in the XSD) to specify the ftpLocalDir configTree parameter,
but that was probably never the intention. It doesn't seem to be getting set on the
FTP EPR (via ListenerUtil.assembleEpr). Has anyone an idea what it was intended for,
considering that the FTPGateway has been working away (in some capacity) without it?
RemoteGatewayListener ignores local FTP location
------------------------------------------------
Key: JBESB-2524
URL: https://jira.jboss.org/jira/browse/JBESB-2524
Project: JBoss ESB
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.4
Reporter: George Gastaldi
Priority: Trivial
Fix For: 4.6
The class RemoteGatewayListener does an ugly checking for the temporary directory and
ignores any attempt to define a local directory:
This is the actual code :
..
protected void checkMyParms() throws ConfigurationException, RegistryException,
GatewayException
{
try
{
File temp = File.createTempFile("FTPdown", ".tmp");
temp.delete();
String localDir = temp.getParent();
if (null==localDir)
localDir=new File("").getAbsolutePath();
config.setAttribute(RemoteFileSystem.PARMS_LOCAL_DIR, localDir);
final String remoteDir = config.getAttribute(ListenerTagNames.FILE_INPUT_DIR_TAG) ;
config.setAttribute(RemoteFileSystem.PARMS_REMOTE_DIR, remoteDir);
EPR epr = ListenerUtil.assembleEpr(config);
if (epr instanceof FTPEpr) {
FTPEpr ftpEpr = (FTPEpr) epr;
RemoteFileSystem rfs = RemoteFileSystemFactory.getRemoteFileSystem(ftpEpr, true);
rfs.quit();
} else {
throw new GatewayException("This Gateway only accepts FTP and SFTP.");
}
}
catch (IOException ex)
{
throw new ConfigurationException(ex);
}
catch (RemoteFileSystemException ex)
{
throw new ConfigurationException(ex);
}
}
...
The Listener should check first if a path has been defined before attempting to discover
the local directory.
BTW, the first lines could be replaced by System.getProperty("java.io.tmpdir"),
instead of creating and deleting a file (expensive unnecessary operation).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:05 a.m.
New subject: [JBoss JIRA] Commented: (JBESB-2524) RemoteGatewayListener ignores local FTP location
[
https://jira.jboss.org/jira/browse/JBESB-2524?page=com.atlassian.jira.plu...
]
Kevin Conner commented on JBESB-2524:
-------------------------------------
The code should be using the system property to obtain the temporary directory, the EPR
has nothing to do with this.
java.io.tmpdir is the property you are after.
RemoteGatewayListener ignores local FTP location
------------------------------------------------
Key: JBESB-2524
URL: https://jira.jboss.org/jira/browse/JBESB-2524
Project: JBoss ESB
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.4
Reporter: George Gastaldi
Priority: Trivial
Fix For: 4.6
The class RemoteGatewayListener does an ugly checking for the temporary directory and
ignores any attempt to define a local directory:
This is the actual code :
..
protected void checkMyParms() throws ConfigurationException, RegistryException,
GatewayException
{
try
{
File temp = File.createTempFile("FTPdown", ".tmp");
temp.delete();
String localDir = temp.getParent();
if (null==localDir)
localDir=new File("").getAbsolutePath();
config.setAttribute(RemoteFileSystem.PARMS_LOCAL_DIR, localDir);
final String remoteDir = config.getAttribute(ListenerTagNames.FILE_INPUT_DIR_TAG) ;
config.setAttribute(RemoteFileSystem.PARMS_REMOTE_DIR, remoteDir);
EPR epr = ListenerUtil.assembleEpr(config);
if (epr instanceof FTPEpr) {
FTPEpr ftpEpr = (FTPEpr) epr;
RemoteFileSystem rfs = RemoteFileSystemFactory.getRemoteFileSystem(ftpEpr, true);
rfs.quit();
} else {
throw new GatewayException("This Gateway only accepts FTP and SFTP.");
}
}
catch (IOException ex)
{
throw new ConfigurationException(ex);
}
catch (RemoteFileSystemException ex)
{
throw new ConfigurationException(ex);
}
}
...
The Listener should check first if a path has been defined before attempting to discover
the local directory.
BTW, the first lines could be replaced by System.getProperty("java.io.tmpdir"),
instead of creating and deleting a file (expensive unnecessary operation).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:16 a.m.
New subject: [JBoss JIRA] Commented: (JBESB-2524) RemoteGatewayListener ignores local FTP location
[
https://jira.jboss.org/jira/browse/JBESB-2524?page=com.atlassian.jira.plu...
]
Tom Fennelly commented on JBESB-2524:
-------------------------------------
Thanks Kev, but that wasn't the question ;)
I asked did anybody know what was the intention of capturing the ftpLocalDir setting? Has
anyone an idea why is it being set on the ConfigTree, since I can't see it ever being
used, which is what I think Gearge means by "RemoteGatewayListener ignores local FTP
location"? If it's not being used for anything, then it's just a case of
removing that code perhaps i.e. not even any need to change it to use the System property.
Maybe I'm blind and it is being used somewhere, but if it is I'd expect it to be
a bit more obvious.
RemoteGatewayListener ignores local FTP location
------------------------------------------------
Key: JBESB-2524
URL: https://jira.jboss.org/jira/browse/JBESB-2524
Project: JBoss ESB
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.4
Reporter: George Gastaldi
Priority: Trivial
Fix For: 4.6
The class RemoteGatewayListener does an ugly checking for the temporary directory and
ignores any attempt to define a local directory:
This is the actual code :
..
protected void checkMyParms() throws ConfigurationException, RegistryException,
GatewayException
{
try
{
File temp = File.createTempFile("FTPdown", ".tmp");
temp.delete();
String localDir = temp.getParent();
if (null==localDir)
localDir=new File("").getAbsolutePath();
config.setAttribute(RemoteFileSystem.PARMS_LOCAL_DIR, localDir);
final String remoteDir = config.getAttribute(ListenerTagNames.FILE_INPUT_DIR_TAG) ;
config.setAttribute(RemoteFileSystem.PARMS_REMOTE_DIR, remoteDir);
EPR epr = ListenerUtil.assembleEpr(config);
if (epr instanceof FTPEpr) {
FTPEpr ftpEpr = (FTPEpr) epr;
RemoteFileSystem rfs = RemoteFileSystemFactory.getRemoteFileSystem(ftpEpr, true);
rfs.quit();
} else {
throw new GatewayException("This Gateway only accepts FTP and SFTP.");
}
}
catch (IOException ex)
{
throw new ConfigurationException(ex);
}
catch (RemoteFileSystemException ex)
{
throw new ConfigurationException(ex);
}
}
...
The Listener should check first if a path has been defined before attempting to discover
the local directory.
BTW, the first lines could be replaced by System.getProperty("java.io.tmpdir"),
instead of creating and deleting a file (expensive unnecessary operation).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:29 a.m.
New subject: [JBoss JIRA] Commented: (JBESB-2524) RemoteGatewayListener ignores local FTP location
[
https://jira.jboss.org/jira/browse/JBESB-2524?page=com.atlassian.jira.plu...
]
Kevin Conner commented on JBESB-2524:
-------------------------------------
Well it is certainly being used in the code, a simple search will find that.
It is passed through the EPR to the remote file system handling code and specifies the
location of the temporary directory.
All that needs to be done for this issue is to remove the creation of the temporary file
creation and replace it with a simple lookup of the system property.
RemoteGatewayListener ignores local FTP location
------------------------------------------------
Key: JBESB-2524
URL: https://jira.jboss.org/jira/browse/JBESB-2524
Project: JBoss ESB
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.4
Reporter: George Gastaldi
Priority: Trivial
Fix For: 4.6
The class RemoteGatewayListener does an ugly checking for the temporary directory and
ignores any attempt to define a local directory:
This is the actual code :
..
protected void checkMyParms() throws ConfigurationException, RegistryException,
GatewayException
{
try
{
File temp = File.createTempFile("FTPdown", ".tmp");
temp.delete();
String localDir = temp.getParent();
if (null==localDir)
localDir=new File("").getAbsolutePath();
config.setAttribute(RemoteFileSystem.PARMS_LOCAL_DIR, localDir);
final String remoteDir = config.getAttribute(ListenerTagNames.FILE_INPUT_DIR_TAG) ;
config.setAttribute(RemoteFileSystem.PARMS_REMOTE_DIR, remoteDir);
EPR epr = ListenerUtil.assembleEpr(config);
if (epr instanceof FTPEpr) {
FTPEpr ftpEpr = (FTPEpr) epr;
RemoteFileSystem rfs = RemoteFileSystemFactory.getRemoteFileSystem(ftpEpr, true);
rfs.quit();
} else {
throw new GatewayException("This Gateway only accepts FTP and SFTP.");
}
}
catch (IOException ex)
{
throw new ConfigurationException(ex);
}
catch (RemoteFileSystemException ex)
{
throw new ConfigurationException(ex);
}
}
...
The Listener should check first if a path has been defined before attempting to discover
the local directory.
BTW, the first lines could be replaced by System.getProperty("java.io.tmpdir"),
instead of creating and deleting a file (expensive unnecessary operation).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:36 a.m.
New subject: [JBoss JIRA] Commented: (JBESB-2524) RemoteGatewayListener ignores local FTP location
[
https://jira.jboss.org/jira/browse/JBESB-2524?page=com.atlassian.jira.plu...
]
Kevin Conner commented on JBESB-2524:
-------------------------------------
In answer to the "RemoteGatewayListener ignores local FTP location" question I
would guess that he is referring to the fact that there is no attempt to check the config
before setting it, which could ne overridden by a property.
RemoteGatewayListener ignores local FTP location
------------------------------------------------
Key: JBESB-2524
URL: https://jira.jboss.org/jira/browse/JBESB-2524
Project: JBoss ESB
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.4
Reporter: George Gastaldi
Priority: Trivial
Fix For: 4.6
The class RemoteGatewayListener does an ugly checking for the temporary directory and
ignores any attempt to define a local directory:
This is the actual code :
..
protected void checkMyParms() throws ConfigurationException, RegistryException,
GatewayException
{
try
{
File temp = File.createTempFile("FTPdown", ".tmp");
temp.delete();
String localDir = temp.getParent();
if (null==localDir)
localDir=new File("").getAbsolutePath();
config.setAttribute(RemoteFileSystem.PARMS_LOCAL_DIR, localDir);
final String remoteDir = config.getAttribute(ListenerTagNames.FILE_INPUT_DIR_TAG) ;
config.setAttribute(RemoteFileSystem.PARMS_REMOTE_DIR, remoteDir);
EPR epr = ListenerUtil.assembleEpr(config);
if (epr instanceof FTPEpr) {
FTPEpr ftpEpr = (FTPEpr) epr;
RemoteFileSystem rfs = RemoteFileSystemFactory.getRemoteFileSystem(ftpEpr, true);
rfs.quit();
} else {
throw new GatewayException("This Gateway only accepts FTP and SFTP.");
}
}
catch (IOException ex)
{
throw new ConfigurationException(ex);
}
catch (RemoteFileSystemException ex)
{
throw new ConfigurationException(ex);
}
}
...
The Listener should check first if a path has been defined before attempting to discover
the local directory.
BTW, the first lines could be replaced by System.getProperty("java.io.tmpdir"),
instead of creating and deleting a file (expensive unnecessary operation).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:55 a.m.
New subject: [JBoss JIRA] Commented: (JBESB-2524) RemoteGatewayListener ignores local FTP location
[
https://jira.jboss.org/jira/browse/JBESB-2524?page=com.atlassian.jira.plu...
]
Tom Fennelly commented on JBESB-2524:
-------------------------------------
OK... so it's official then... I am as blind as a bat!! Don't ask me how I
didn't see the usages of that constant, but as you say, they are obvious to be seen
there after a simple search. Duh!!
RemoteGatewayListener ignores local FTP location
------------------------------------------------
Key: JBESB-2524
URL: https://jira.jboss.org/jira/browse/JBESB-2524
Project: JBoss ESB
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.4
Reporter: George Gastaldi
Priority: Trivial
Fix For: 4.6
The class RemoteGatewayListener does an ugly checking for the temporary directory and
ignores any attempt to define a local directory:
This is the actual code :
..
protected void checkMyParms() throws ConfigurationException, RegistryException,
GatewayException
{
try
{
File temp = File.createTempFile("FTPdown", ".tmp");
temp.delete();
String localDir = temp.getParent();
if (null==localDir)
localDir=new File("").getAbsolutePath();
config.setAttribute(RemoteFileSystem.PARMS_LOCAL_DIR, localDir);
final String remoteDir = config.getAttribute(ListenerTagNames.FILE_INPUT_DIR_TAG) ;
config.setAttribute(RemoteFileSystem.PARMS_REMOTE_DIR, remoteDir);
EPR epr = ListenerUtil.assembleEpr(config);
if (epr instanceof FTPEpr) {
FTPEpr ftpEpr = (FTPEpr) epr;
RemoteFileSystem rfs = RemoteFileSystemFactory.getRemoteFileSystem(ftpEpr, true);
rfs.quit();
} else {
throw new GatewayException("This Gateway only accepts FTP and SFTP.");
}
}
catch (IOException ex)
{
throw new ConfigurationException(ex);
}
catch (RemoteFileSystemException ex)
{
throw new ConfigurationException(ex);
}
}
...
The Listener should check first if a path has been defined before attempting to discover
the local directory.
BTW, the first lines could be replaced by System.getProperty("java.io.tmpdir"),
instead of creating and deleting a file (expensive unnecessary operation).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:59 a.m.
New subject: [JBoss JIRA] Commented: (JBESB-2524) RemoteGatewayListener ignores local FTP location
[
https://jira.jboss.org/jira/browse/JBESB-2524?page=com.atlassian.jira.plu...
]
Kevin Conner commented on JBESB-2524:
-------------------------------------
Except you are not so blind :)
The parameter should be getting passed through as part of the EPR but, as you mentioned
earlier, this does not appear to be happening. At least if it is then I cannot find it
:)
So we are both blind as bats :)
RemoteGatewayListener ignores local FTP location
------------------------------------------------
Key: JBESB-2524
URL: https://jira.jboss.org/jira/browse/JBESB-2524
Project: JBoss ESB
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.4
Reporter: George Gastaldi
Priority: Trivial
Fix For: 4.6
The class RemoteGatewayListener does an ugly checking for the temporary directory and
ignores any attempt to define a local directory:
This is the actual code :
..
protected void checkMyParms() throws ConfigurationException, RegistryException,
GatewayException
{
try
{
File temp = File.createTempFile("FTPdown", ".tmp");
temp.delete();
String localDir = temp.getParent();
if (null==localDir)
localDir=new File("").getAbsolutePath();
config.setAttribute(RemoteFileSystem.PARMS_LOCAL_DIR, localDir);
final String remoteDir = config.getAttribute(ListenerTagNames.FILE_INPUT_DIR_TAG) ;
config.setAttribute(RemoteFileSystem.PARMS_REMOTE_DIR, remoteDir);
EPR epr = ListenerUtil.assembleEpr(config);
if (epr instanceof FTPEpr) {
FTPEpr ftpEpr = (FTPEpr) epr;
RemoteFileSystem rfs = RemoteFileSystemFactory.getRemoteFileSystem(ftpEpr, true);
rfs.quit();
} else {
throw new GatewayException("This Gateway only accepts FTP and SFTP.");
}
}
catch (IOException ex)
{
throw new ConfigurationException(ex);
}
catch (RemoteFileSystemException ex)
{
throw new ConfigurationException(ex);
}
}
...
The Listener should check first if a path has been defined before attempting to discover
the local directory.
BTW, the first lines could be replaced by System.getProperty("java.io.tmpdir"),
instead of creating and deleting a file (expensive unnecessary operation).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:07 a.m.
New subject: [JBoss JIRA] Commented: (JBESB-2524) RemoteGatewayListener ignores local FTP location
[
https://jira.jboss.org/jira/browse/JBESB-2524?page=com.atlassian.jira.plu...
]
Tom Fennelly commented on JBESB-2524:
-------------------------------------
OK... maybe I just drilled into ListenerUtil.assembleEpr and couldn't see it being
used anywhere after that (set on the EPR etc). I probably didn't even do a usages
search :)
Should we break this issue into 2... I know the System property one is trivial, but it is
separate.
RemoteGatewayListener ignores local FTP location
------------------------------------------------
Key: JBESB-2524
URL: https://jira.jboss.org/jira/browse/JBESB-2524
Project: JBoss ESB
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.4
Reporter: George Gastaldi
Priority: Trivial
Fix For: 4.6
The class RemoteGatewayListener does an ugly checking for the temporary directory and
ignores any attempt to define a local directory:
This is the actual code :
..
protected void checkMyParms() throws ConfigurationException, RegistryException,
GatewayException
{
try
{
File temp = File.createTempFile("FTPdown", ".tmp");
temp.delete();
String localDir = temp.getParent();
if (null==localDir)
localDir=new File("").getAbsolutePath();
config.setAttribute(RemoteFileSystem.PARMS_LOCAL_DIR, localDir);
final String remoteDir = config.getAttribute(ListenerTagNames.FILE_INPUT_DIR_TAG) ;
config.setAttribute(RemoteFileSystem.PARMS_REMOTE_DIR, remoteDir);
EPR epr = ListenerUtil.assembleEpr(config);
if (epr instanceof FTPEpr) {
FTPEpr ftpEpr = (FTPEpr) epr;
RemoteFileSystem rfs = RemoteFileSystemFactory.getRemoteFileSystem(ftpEpr, true);
rfs.quit();
} else {
throw new GatewayException("This Gateway only accepts FTP and SFTP.");
}
}
catch (IOException ex)
{
throw new ConfigurationException(ex);
}
catch (RemoteFileSystemException ex)
{
throw new ConfigurationException(ex);
}
}
...
The Listener should check first if a path has been defined before attempting to discover
the local directory.
BTW, the first lines could be replaced by System.getProperty("java.io.tmpdir"),
instead of creating and deleting a file (expensive unnecessary operation).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:15 a.m.
New subject: [JBoss JIRA] Commented: (JBESB-2524) RemoteGatewayListener ignores local FTP location
[
https://jira.jboss.org/jira/browse/JBESB-2524?page=com.atlassian.jira.plu...
]
Kevin Conner commented on JBESB-2524:
-------------------------------------
Sounds like a good idea, go for it.
RemoteGatewayListener ignores local FTP location
------------------------------------------------
Key: JBESB-2524
URL: https://jira.jboss.org/jira/browse/JBESB-2524
Project: JBoss ESB
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.4
Reporter: George Gastaldi
Priority: Trivial
Fix For: 4.6
The class RemoteGatewayListener does an ugly checking for the temporary directory and
ignores any attempt to define a local directory:
This is the actual code :
..
protected void checkMyParms() throws ConfigurationException, RegistryException,
GatewayException
{
try
{
File temp = File.createTempFile("FTPdown", ".tmp");
temp.delete();
String localDir = temp.getParent();
if (null==localDir)
localDir=new File("").getAbsolutePath();
config.setAttribute(RemoteFileSystem.PARMS_LOCAL_DIR, localDir);
final String remoteDir = config.getAttribute(ListenerTagNames.FILE_INPUT_DIR_TAG) ;
config.setAttribute(RemoteFileSystem.PARMS_REMOTE_DIR, remoteDir);
EPR epr = ListenerUtil.assembleEpr(config);
if (epr instanceof FTPEpr) {
FTPEpr ftpEpr = (FTPEpr) epr;
RemoteFileSystem rfs = RemoteFileSystemFactory.getRemoteFileSystem(ftpEpr, true);
rfs.quit();
} else {
throw new GatewayException("This Gateway only accepts FTP and SFTP.");
}
}
catch (IOException ex)
{
throw new ConfigurationException(ex);
}
catch (RemoteFileSystemException ex)
{
throw new ConfigurationException(ex);
}
}
...
The Listener should check first if a path has been defined before attempting to discover
the local directory.
BTW, the first lines could be replaced by System.getProperty("java.io.tmpdir"),
instead of creating and deleting a file (expensive unnecessary operation).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:11 a.m.
New subject: [JBoss JIRA] Commented: (JBESB-2524) RemoteGatewayListener ignores local FTP location
[
https://jira.jboss.org/jira/browse/JBESB-2524?page=com.atlassian.jira.plu...
]
Kevin Conner commented on JBESB-2524:
-------------------------------------
Having thought about this over the weekend I am not convinced that the local dir should
ever be part of the EPR. The local dir should be configured on the system that is using
the EPR and is likely to be different depending on external factors (windows, unix, local
permissions etc).
I think it would be better to remove the local dir from this configuration.
RemoteGatewayListener ignores local FTP location
------------------------------------------------
Key: JBESB-2524
URL: https://jira.jboss.org/jira/browse/JBESB-2524
Project: JBoss ESB
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.4
Reporter: George Gastaldi
Priority: Trivial
Fix For: 4.6
The class RemoteGatewayListener does an ugly checking for the temporary directory and
ignores any attempt to define a local directory:
This is the actual code :
..
protected void checkMyParms() throws ConfigurationException, RegistryException,
GatewayException
{
try
{
File temp = File.createTempFile("FTPdown", ".tmp");
temp.delete();
String localDir = temp.getParent();
if (null==localDir)
localDir=new File("").getAbsolutePath();
config.setAttribute(RemoteFileSystem.PARMS_LOCAL_DIR, localDir);
final String remoteDir = config.getAttribute(ListenerTagNames.FILE_INPUT_DIR_TAG) ;
config.setAttribute(RemoteFileSystem.PARMS_REMOTE_DIR, remoteDir);
EPR epr = ListenerUtil.assembleEpr(config);
if (epr instanceof FTPEpr) {
FTPEpr ftpEpr = (FTPEpr) epr;
RemoteFileSystem rfs = RemoteFileSystemFactory.getRemoteFileSystem(ftpEpr, true);
rfs.quit();
} else {
throw new GatewayException("This Gateway only accepts FTP and SFTP.");
}
}
catch (IOException ex)
{
throw new ConfigurationException(ex);
}
catch (RemoteFileSystemException ex)
{
throw new ConfigurationException(ex);
}
}
...
The Listener should check first if a path has been defined before attempting to discover
the local directory.
BTW, the first lines could be replaced by System.getProperty("java.io.tmpdir"),
instead of creating and deleting a file (expensive unnecessary operation).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:06 a.m.
New subject: [JBoss JIRA] Commented: (JBESB-2524) RemoteGatewayListener ignores local FTP location
[
https://jira.jboss.org/jira/browse/JBESB-2524?page=com.atlassian.jira.plu...
]
Tom Fennelly commented on JBESB-2524:
-------------------------------------
+1... I was also thinking this, but was half afraid to suggest it :)
I will remove the code (from RemoteGatewayListener) that suggests an intention to
configure this at the EPR level (but doesn't in reality).
RemoteGatewayListener ignores local FTP location
------------------------------------------------
Key: JBESB-2524
URL: https://jira.jboss.org/jira/browse/JBESB-2524
Project: JBoss ESB
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.4
Reporter: George Gastaldi
Priority: Trivial
Fix For: 4.6
The class RemoteGatewayListener does an ugly checking for the temporary directory and
ignores any attempt to define a local directory:
This is the actual code :
..
protected void checkMyParms() throws ConfigurationException, RegistryException,
GatewayException
{
try
{
File temp = File.createTempFile("FTPdown", ".tmp");
temp.delete();
String localDir = temp.getParent();
if (null==localDir)
localDir=new File("").getAbsolutePath();
config.setAttribute(RemoteFileSystem.PARMS_LOCAL_DIR, localDir);
final String remoteDir = config.getAttribute(ListenerTagNames.FILE_INPUT_DIR_TAG) ;
config.setAttribute(RemoteFileSystem.PARMS_REMOTE_DIR, remoteDir);
EPR epr = ListenerUtil.assembleEpr(config);
if (epr instanceof FTPEpr) {
FTPEpr ftpEpr = (FTPEpr) epr;
RemoteFileSystem rfs = RemoteFileSystemFactory.getRemoteFileSystem(ftpEpr, true);
rfs.quit();
} else {
throw new GatewayException("This Gateway only accepts FTP and SFTP.");
}
}
catch (IOException ex)
{
throw new ConfigurationException(ex);
}
catch (RemoteFileSystemException ex)
{
throw new ConfigurationException(ex);
}
}
...
The Listener should check first if a path has been defined before attempting to discover
the local directory.
BTW, the first lines could be replaced by System.getProperty("java.io.tmpdir"),
instead of creating and deleting a file (expensive unnecessary operation).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:55 a.m.
New subject: [JBoss JIRA] Assigned: (JBESB-2524) RemoteGatewayListener ignores local FTP location
[
https://jira.jboss.org/jira/browse/JBESB-2524?page=com.atlassian.jira.plu...
]
Tom Fennelly reassigned JBESB-2524:
-----------------------------------
Assignee: Tom Fennelly
RemoteGatewayListener ignores local FTP location
------------------------------------------------
Key: JBESB-2524
URL: https://jira.jboss.org/jira/browse/JBESB-2524
Project: JBoss ESB
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.4
Reporter: George Gastaldi
Assignee: Tom Fennelly
Priority: Trivial
Fix For: 4.6
The class RemoteGatewayListener does an ugly checking for the temporary directory and
ignores any attempt to define a local directory:
This is the actual code :
..
protected void checkMyParms() throws ConfigurationException, RegistryException,
GatewayException
{
try
{
File temp = File.createTempFile("FTPdown", ".tmp");
temp.delete();
String localDir = temp.getParent();
if (null==localDir)
localDir=new File("").getAbsolutePath();
config.setAttribute(RemoteFileSystem.PARMS_LOCAL_DIR, localDir);
final String remoteDir = config.getAttribute(ListenerTagNames.FILE_INPUT_DIR_TAG) ;
config.setAttribute(RemoteFileSystem.PARMS_REMOTE_DIR, remoteDir);
EPR epr = ListenerUtil.assembleEpr(config);
if (epr instanceof FTPEpr) {
FTPEpr ftpEpr = (FTPEpr) epr;
RemoteFileSystem rfs = RemoteFileSystemFactory.getRemoteFileSystem(ftpEpr, true);
rfs.quit();
} else {
throw new GatewayException("This Gateway only accepts FTP and SFTP.");
}
}
catch (IOException ex)
{
throw new ConfigurationException(ex);
}
catch (RemoteFileSystemException ex)
{
throw new ConfigurationException(ex);
}
}
...
The Listener should check first if a path has been defined before attempting to discover
the local directory.
BTW, the first lines could be replaced by System.getProperty("java.io.tmpdir"),
instead of creating and deleting a file (expensive unnecessary operation).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:58 a.m.
New subject: [JBoss JIRA] Closed: (JBESB-2524) RemoteGatewayListener ignores local FTP location
[
https://jira.jboss.org/jira/browse/JBESB-2524?page=com.atlassian.jira.plu...
]
Tom Fennelly closed JBESB-2524.
-------------------------------
Resolution: Done
trunk: 27282
RemoteGatewayListener ignores local FTP location
------------------------------------------------
Key: JBESB-2524
URL: https://jira.jboss.org/jira/browse/JBESB-2524
Project: JBoss ESB
Issue Type: Patch
Security Level: Public(Everyone can see)
Components: Transports
Affects Versions: 4.4
Reporter: George Gastaldi
Assignee: Tom Fennelly
Priority: Trivial
Fix For: 4.6
The class RemoteGatewayListener does an ugly checking for the temporary directory and
ignores any attempt to define a local directory:
This is the actual code :
..
protected void checkMyParms() throws ConfigurationException, RegistryException,
GatewayException
{
try
{
File temp = File.createTempFile("FTPdown", ".tmp");
temp.delete();
String localDir = temp.getParent();
if (null==localDir)
localDir=new File("").getAbsolutePath();
config.setAttribute(RemoteFileSystem.PARMS_LOCAL_DIR, localDir);
final String remoteDir = config.getAttribute(ListenerTagNames.FILE_INPUT_DIR_TAG) ;
config.setAttribute(RemoteFileSystem.PARMS_REMOTE_DIR, remoteDir);
EPR epr = ListenerUtil.assembleEpr(config);
if (epr instanceof FTPEpr) {
FTPEpr ftpEpr = (FTPEpr) epr;
RemoteFileSystem rfs = RemoteFileSystemFactory.getRemoteFileSystem(ftpEpr, true);
rfs.quit();
} else {
throw new GatewayException("This Gateway only accepts FTP and SFTP.");
}
}
catch (IOException ex)
{
throw new ConfigurationException(ex);
}
catch (RemoteFileSystemException ex)
{
throw new ConfigurationException(ex);
}
}
...
The Listener should check first if a path has been defined before attempting to discover
the local directory.
BTW, the first lines could be replaced by System.getProperty("java.io.tmpdir"),
instead of creating and deleting a file (expensive unnecessary operation).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6141
days inactive
6216
days old
14 comments
3 participants
participants (3)
-
George Gastaldi (JIRA) -
Kevin Conner (JIRA)
-
Tom Fennelly (JIRA)