[esb-issues] [JBoss JIRA] Created: (JBESB-2524) RemoteGatewayListener ignores local FTP location
RemoteGatewayListener ignores local FTP location
------------------------------------------------
Key: JBESB-2524
URL: https://jira.jboss.org/jira/browse/JBESB-2524
Project: JBoss ESB
Issue Type: Patch
Security Level: Public (Everyone can see)
Affects Versions: 4.4
Reporter: George Gastaldi
Priority: Trivial
The class RemoteGatewayListener does an ugly checking for the temporary directory and
ignores any attempt to define a local directory:
This is the actual code :
..
protected void checkMyParms() throws ConfigurationException, RegistryException,
GatewayException
{
try
{
File temp = File.createTempFile("FTPdown", ".tmp");
temp.delete();
String localDir = temp.getParent();
if (null==localDir)
localDir=new File("").getAbsolutePath();
config.setAttribute(RemoteFileSystem.PARMS_LOCAL_DIR, localDir);
final String remoteDir = config.getAttribute(ListenerTagNames.FILE_INPUT_DIR_TAG) ;
config.setAttribute(RemoteFileSystem.PARMS_REMOTE_DIR, remoteDir);
EPR epr = ListenerUtil.assembleEpr(config);
if (epr instanceof FTPEpr) {
FTPEpr ftpEpr = (FTPEpr) epr;
RemoteFileSystem rfs = RemoteFileSystemFactory.getRemoteFileSystem(ftpEpr, true);
rfs.quit();
} else {
throw new GatewayException("This Gateway only accepts FTP and SFTP.");
}
}
catch (IOException ex)
{
throw new ConfigurationException(ex);
}
catch (RemoteFileSystemException ex)
{
throw new ConfigurationException(ex);
}
}
...
The Listener should check first if a path has been defined before attempting to discover
the local directory.
BTW, the first lines could be replaced by System.getProperty("java.io.tmpdir"),
instead of creating and deleting a file (expensive unnecessary operation).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira