[exo-jcr-commits] exo-jcr SVN: r1350 - in jcr/branches/1.12.0-OPT/exo.jcr.component.core/src: test/java/org/exoplatform/services/jcr/impl/dataflow/session and 1 other directory.
Author: tolusha
Date: 2010-01-12 04:38:47 -0500 (Tue, 12 Jan 2010)
New Revision: 1350
Modified:
jcr/branches/1.12.0-OPT/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/dataflow/session/SessionChangesLog.java
jcr/branches/1.12.0-OPT/exo.jcr.component.core/src/test/java/org/exoplatform/services/jcr/impl/dataflow/session/SessionChangesLogTest.java
Log:
EXOJCR-377: Check hashcode calculation of item in SessionChangesLog
Modified:
jcr/branches/1.12.0-OPT/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/dataflow/session/SessionChangesLog.java
===================================================================
---
jcr/branches/1.12.0-OPT/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/dataflow/session/SessionChangesLog.java 2010-01-11
17:55:56 UTC (rev 1349)
+++
jcr/branches/1.12.0-OPT/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/dataflow/session/SessionChangesLog.java 2010-01-12
09:38:47 UTC (rev 1350)
@@ -756,7 +756,7 @@
result = prime * result + name.getName().hashCode();
result = prime * result + name.getNamespace().hashCode();
result = prime * result + name.getIndex();
- result = prime * result + parentIdentifier.hashCode();
+ result = prime * result + (parentIdentifier == null ? 0 :
parentIdentifier.hashCode());
return result;
}
Modified:
jcr/branches/1.12.0-OPT/exo.jcr.component.core/src/test/java/org/exoplatform/services/jcr/impl/dataflow/session/SessionChangesLogTest.java
===================================================================
---
jcr/branches/1.12.0-OPT/exo.jcr.component.core/src/test/java/org/exoplatform/services/jcr/impl/dataflow/session/SessionChangesLogTest.java 2010-01-11
17:55:56 UTC (rev 1349)
+++
jcr/branches/1.12.0-OPT/exo.jcr.component.core/src/test/java/org/exoplatform/services/jcr/impl/dataflow/session/SessionChangesLogTest.java 2010-01-12
09:38:47 UTC (rev 1350)
@@ -20,6 +20,7 @@
import org.exoplatform.services.jcr.JcrImplBaseTest;
import org.exoplatform.services.jcr.dataflow.ItemState;
+import org.exoplatform.services.jcr.dataflow.persistent.PersistedPropertyData;
import org.exoplatform.services.jcr.datamodel.InternalQName;
import org.exoplatform.services.jcr.datamodel.NodeData;
import org.exoplatform.services.jcr.impl.Constants;
@@ -244,4 +245,18 @@
// assertEquals("No session should be linked ", 0, linked);
}
+
+ public void testAddRootChanges() throws Exception
+ {
+ SessionChangesLog changesLog = new SessionChangesLog(session.getId());
+ try
+ {
+ changesLog.add(new ItemState(new TransientPropertyData(Constants.ROOT_PATH,
Constants.ROOT_UUID, 0,
+ PropertyType.STRING, null, false), ItemState.ADDED, false,
Constants.ROOT_PATH));
+ }
+ catch (Exception e)
+ {
+ fail("Exception should not be thrown");
+ }
+ }
}