5 p.m.
On 13/03/13 21:19, Julien Viet wrote:
On Mar 13, 2013, at 8:17 PM, Marek Posolda
<mposolda(a)redhat.com> wrote:
> Hi Julien,
>
> is there something special which could be done to reproduce the issue? I tried to
verify with latest GateIn master and Tomcat 7.0.32 but not seeing any problems. Do I need
to use some web application with servlet 3.0 descriptor? Do you have some app to share
which could be use to reproduce this?
Hoang reported this issue. I will ask him to provide the necessary steps for reproducing
(like a war file).
> Actually picketlink-jbas7 is not part of Tomcat packaging. I am not seeing it in
GATEIN_TOMCAT_HOME/lib/ . But SSODelegateValve is part of sso-integration-1.3.1.Final.jar
which is part of Tomcat packaging…
> Thing is that signature of PortalClusteredSSOSupportValve is:
> {code}
> public class PortalClusteredSSOSupportValve extends ValveBase implements Lifecycle {
> {code}
>
> but signature of SSODelegateValve is:
> {code}
> public class SSODelegateValve implements Valve, Contained, MBeanRegistration,
Lifecycle
> {code}
>
> So it seems that your issue with "class
org.exoplatform.web.login.PortalClusteredSSOSupportValve overrides final method
start.()" really won't happen for SSODelegateValve. Hard to say without being
able
> to reproduce…
That would be a good news.
Does the SSODelegateValve also work on Tomcat ? or is it AS7 specific ?
It's
used for SSO scenarios with SPNEGO and SAML. Both are documented
and tested only for AS7.
Marek
> Marek
>
>
> On 13/03/13 10:16, Julien Viet wrote:
>> it looks like the dependency comes from PicketLink artifact picketlink-jbas7 that
contains specific code for JBoss AS7 (JBoss Web).
>>
>> we need to come up with a solution that erases this dependency from non JBoss AS7
runtimes :-)
>>
>> On Mar 13, 2013, at 10:10 AM, Julien Viet <julien(a)julienviet.com> wrote:
>>
>>> we need this valve to be moved to a JBoss AS specific jar, can you take care
of this ?
>>>
>>> On Mar 11, 2013, at 9:34 PM, Marek Posolda <mposolda(a)redhat.com>
wrote:
>>>
>>>> On 11/03/13 21:25, Julien Viet wrote:
>>>>> PortalClusteredSSOSupportValve is the only Tomcat valve used in
GateIn and it is only used in JBoss AS7 for clustered SSO.
>>>>>
>>>>> did you have something else in mind ?
>>>> yeah, I already mentioned in first mail that I am aware at least about
SSODelegateValve.
>>>>
>>>> Marek
>>>>> On Mar 11, 2013, at 8:32 PM, Marek Posolda
<mposolda(a)redhat.com> wrote:
>>>>>
>>>>>> On 11/03/13 18:44, Julien Viet wrote:
>>>>>>> why wouldn't it be sufficient ?
>>>>>> Because we have more valve classes, not just
PortalClusteredSSOSupportValve. So it's possible that when you fix
PortalClusteredSSOSupportValve and move it to packaging/jboss-as7, you will still see same
error for some other valve class. But maybe I am wrong, I did not try it...
>>>>>>
>>>>>> Marek
>>>>>>> On Mar 11, 2013, at 6:33 PM, Marek Posolda
<mposolda(a)redhat.com> wrote:
>>>>>>>
>>>>>>>> This api inconsistency between Tomcat and JBossWeb really
sucks:-(
>>>>>>>>
>>>>>>>> I think that PortalClusteredSSOSupportValve is not the
only one valve class, which implements start() method. We have more such valve classes (I
am aware at least about SSODelegateValve). So it seems that moving single
PortalClusteredSSOSupportValve to packaging/jboss-as7 won't be sufficient...
>>>>>>>>
>>>>>>>> Can't we do something like override tomcat
classloader org.apache.catalina.loader.WebappClassLoader and handle this at classloader
level?
>>>>>>>>
>>>>>>>> Marek
>>>>>>>>
>>>>>>>> On 08/03/13 11:19, Julien Viet wrote:
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> there is an issue when deploying servlet 3.0
applications on Tomcat with PortalClusteredSSOSupportValve.
>>>>>>>>>
>>>>>>>>> The scanning process find this valve and a
classloading issue occurs (JBoss AS7 uses a Tomcat fork with slightly different code) and
produces this error:
>>>>>>>>>
>>>>>>>>> https://gist.github.com/vietj/b35b65f7dbe9d845ddd3
>>>>>>>>>
>>>>>>>>> It would make sense at some point to move this code
to gatein-sso (or wci) but I think it would not work at the moment.
>>>>>>>>>
>>>>>>>>> An easy solution would be to move this class
somewhere in packaging/jboss-as7 .
>>>>>>>>>
>>>>>>>>> Would someone mind to have a look at this issue ?
>>>>>>>>>
>>>>>>>>> thanks
>>>>>>>>>
>>>>>>>>> Julien
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> gatein-dev mailing list
>>>>>>>>> gatein-dev(a)lists.jboss.org
>>>>>>>>> https://lists.jboss.org/mailman/listinfo/gatein-dev